Skip to content

Commit f9266f3

Browse files
authored
Merge pull request #6 from sandman21vs/close-wallet-label
Call the way out of the wallet what it does
2 parents e2e725d + a1ece52 commit f9266f3

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ never padded with blank rows. Only labels are listed. Values meant to be transcr
302302
instead, split by what fits the display.
303303

304304
The last row of every list with somewhere to return to is the way out of it —
305-
`Back`, `Done / erase`, `[delete]` — and a rule is drawn above it so it is not
305+
`Back`, `Erase and exit`, `[delete]` — and a rule is drawn above it so it is not
306306
read as one more choice. That row is always last, in every such list, so
307307
leaving a screen is always in the same place. The one list with nowhere to
308308
return to is the main menu itself: there is no `Back` row there, and the

‎host/origo_simulator.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ static bool word_numbers_round_trip_is_sound(void)
431431
* last glyph that fits; nothing here is transcribed, but a silently shortened
432432
* label still misnames what the buttons are about to do. */
433433
static const char* const menu_labels[] = { "Master fingerprint", "Native SegWit (BIP84)", "Taproot (BIP86)",
434-
"Account key", "Addresses", "Account key format", "xpub", "zpub", "Done / erase", "New Seed", "From entropy",
434+
"Account key", "Addresses", "Account key format", "xpub", "zpub", "Erase and exit", "New Seed", "From entropy",
435435
"Restore Seed", "Complete checksum", "About", "Settings", "11 words + 7 coins", "23 words + 3 coins",
436436
"No passphrase", "Enter passphrase", "D6 dice", "D20 dice", "Coin flips", "Cards", "Back", "12 words",
437437
"24 words", "[delete]", "[back]", "Type the letters", "Enter word numbers", "Plain text", "Backup",

‎main/seedtool_app.c‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1266,7 +1266,7 @@ static int review_and_confirm(char words[][SEEDTOOL_MAX_WORD_LEN + 1], const siz
12661266
* address_labels: these rows are the mnemonic in plain text, one word
12671267
* each, and they live in .bss rather than on a stack frame that the next
12681268
* screen would overwrite anyway. Leaving them behind kept a restored seed
1269-
* readable in RAM for the rest of the session - past "Done / erase" and
1269+
* readable in RAM for the rest of the session - past "Erase and exit" and
12701270
* past the session-timeout screen, which erases nothing here. Clearing on
12711271
* entry as well as exit keeps a 12-word restore from leaving rows 12..23
12721272
* of a previous 24-word one on show. */
@@ -2149,7 +2149,7 @@ static void show_wallet_data(const char* mnemonic)
21492149
(void)snprintf(wallet_title, sizeof(wallet_title), "Wallet @%s", fphex);
21502150
size_t cursor = 0;
21512151
for (;;) {
2152-
const char* menu[] = { "Backup", "Extended public key", "Derivation", "Addresses", "Done / erase" };
2152+
const char* menu[] = { "Backup", "Extended public key", "Derivation", "Addresses", "Erase and exit" };
21532153
const int selected = choose_kept(wallet_title, menu, sizeof(menu) / sizeof(menu[0]), true, &cursor);
21542154
if (selected < 0 || selected == 4) {
21552155
break;
@@ -2539,7 +2539,7 @@ static int collect_entropy(const int source, const size_t words)
25392539
}
25402540

25412541
/* Returns whether a seed was actually generated and carried all the way
2542-
* through the wallet viewer to Done/erase (or a timeout) - as opposed to the
2542+
* through the wallet viewer to Erase and exit (or a timeout) - as opposed to the
25432543
* reader backing out of the source or length picker before ever starting.
25442544
* show_new_seed_menu uses this to tell "done, go all the way home" apart from
25452545
* plain "back one level". */
@@ -2643,10 +2643,10 @@ static void show_new_seed_menu(void)
26432643
if (selected < 0 || selected == 2) {
26442644
return;
26452645
}
2646-
/* A seed that made it all the way to Done/erase (or a timeout) closes
2646+
/* A seed that made it all the way to Erase and exit (or a timeout) closes
26472647
* this menu too, straight back to the Origo/Home menu, rather than
26482648
* reopening "New Seed" - that reopening was the actual bug: pressing
2649-
* Done/erase landed back inside New Seed instead of at Home. Backing
2649+
* Erase and exit landed back inside New Seed instead of at Home. Backing
26502650
* out of the source/length picker before anything was generated
26512651
* keeps the old "one level up" behaviour. */
26522652
if (selected == 0 ? create_seed() : complete_checksum()) {

‎main/seedtool_render.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -485,8 +485,8 @@ void seedtool_render_list(const char* title, const char* const* items, const siz
485485
const char* const item = items[top + row];
486486
const bool highlighted = top + row == selected;
487487
const int y = LIST_TOP + (int)row * LIST_ROW_HEIGHT;
488-
/* The last row of every list is the way out of it — Back, Reboot,
489-
* Done / erase, [delete]. A rule above it lifts it out of the choices,
488+
/* The last row of every list is the way out of it — Back, Erase and
489+
* exit, [delete]. A rule above it lifts it out of the choices,
490490
* which is what it is not. It goes in the gap between cells so the
491491
* selection bar never paints over it. */
492492
if (top + row == count - 1 && count > 1) {

0 commit comments

Comments
 (0)