Repository navigation
Conversation
A host backend that feeds seedtool_run scripted keys on a virtual clock and prints a hash of every frame, so a change to the app can be checked to leave every screen as it was.
The app, renderer and tests explained their own history at length; keep what a reader needs to check the code and drop how it got here. Several render comments described the QR layout the wrong way round and are now correct. No code changes; POLL_MS reads 10, the tick it already rounded to.
wait_key never returns a timeout now, so the entry screens and flows lose their third outcome and return whether the reader went on or back; conditions that cannot happen restart through seedtool_require. Merge the two review lists, the account and index keypads and the three coin-flip loops. Replaying 5000 random key scripts draws the same frames before and after.
Screen machinery, mnemonic entry, the wallet and the ways a seed is made each get a file; app_internal.h holds what they share. Functions move unchanged, and the 5000-script replay draws the same frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four commits, all verified the same way. A new host tool,
origo-replay, runs the app from a key script on a virtual clock and prints a hash of every frame. 5000 random scripts, recorded before these changes, reach 91% of the app's lines, and replay to the same frames after each commit.gcc -fpreprocessed. Several render comments described the QR layout the wrong way round and are now correct.wait_keynever returns a timeout since Navigate with two buttons and type words on a filtered keyboard #1, so the entry screens and flows return whether the reader went on or back. Conditions that cannot happen restart throughseedtool_require. The two review lists, the account and index keypads, and the three coin-flip loops are merged.app_ui.c,app_words.c,app_wallet.c,app_seed.c, withapp_internal.hfor what they share. Functions move unchanged;seedtool_app.ckeeps the top level.Verified with: the replay above (0 of 5000 runs differ after each commit),
ctestplain and under ASan/UBSan, Python tests, 60 s fuzz, firmware built twice inespressif/idf:v5.5.4with audit andcmp.