Commit 6619625
committed
Fix clipped icon-circle by moving scroll to the overlay
The dialog card had `max-height: calc(100vh - 64px)` and
`overflow-y: auto`, intended to handle tall forms. But the top
icon-circle is positioned at `top: -32px` — it sticks out above the
card. With `overflow-y: auto` on the card, that protruding icon was
being clipped, leaving the dialog looking like a plain rectangle
instead of the rounded card with the half-arc icon-circle on top
(matching the confirm-dialog look).
Move scroll handling to the overlay instead:
- `.dialog-overlay` now has `overflow-y: auto` so the viewport itself
scrolls if the card is taller than the screen.
- `align-items: safe center` keeps short dialogs vertically centered
but switches to top-aligned automatically when the card is tall —
this is the modern CSS pattern that handles both cases.
- Top/bottom padding bumped to 48px so the icon-circle has space
even when the dialog is positioned at the top of the scroll area.
- `.dialog-card` drops `max-height` and `overflow-y`, explicitly sets
`overflow: visible` (with a comment explaining why it must stay
visible) so the icon-circle is never clipped.
The card now matches the confirm-dialog visual contract exactly:
rounded 12px corners, the 64px icon-circle protruding 32px above the
card with its half-arc colored border.1 parent b3e9412 commit 6619625
1 file changed
Lines changed: 13 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
472 | 472 | | |
473 | 473 | | |
474 | 474 | | |
475 | | - | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
476 | 481 | | |
477 | 482 | | |
478 | 483 | | |
479 | 484 | | |
480 | 485 | | |
481 | | - | |
| 486 | + | |
482 | 487 | | |
483 | | - | |
| 488 | + | |
484 | 489 | | |
485 | 490 | | |
486 | 491 | | |
| 492 | + | |
487 | 493 | | |
488 | 494 | | |
489 | 495 | | |
| |||
519 | 525 | | |
520 | 526 | | |
521 | 527 | | |
522 | | - | |
523 | | - | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
524 | 532 | | |
525 | 533 | | |
526 | 534 | | |
| |||
0 commit comments