Skip to content

feat!: remove cis-xlsx-to-oscal-catalog task - #2156

Open
rishi-jat wants to merge 1 commit into
oscal-compass:developfrom
rishi-jat:remove-cis-xlsx-to-oscal-catalog
Open

feat!: remove cis-xlsx-to-oscal-catalog task#2156
rishi-jat wants to merge 1 commit into
oscal-compass:developfrom
rishi-jat:remove-cis-xlsx-to-oscal-catalog

Conversation

@rishi-jat

Copy link
Copy Markdown
Contributor

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (change which affects the documentation site)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Closes #1811

This PR removes the cis-xlsx-to-oscal-catalog task.

As discussed in the issue, this task incorrectly transformed CIS Benchmarks into OSCAL Catalogs. Since CIS Benchmarks represent OSCAL Component Definitions, the correct task to use is cis-xlsx-to-oscal-cd.

Changes Included

  • Removed task implementation (trestle/tasks/cis_xlsx_to_oscal_catalog.py)
  • Removed associated tests and test data
  • Removed API documentation for the task
  • Removed all references to the deprecated task

This is a breaking change intended for the v4 release per the guidance in issue #1811.

BREAKING CHANGE: Removed cis-xlsx-to-oscal-catalog task. Use cis-xlsx-to-oscal-cd instead.

Signed-off-by: Rishi Jat <rishijat098@gmail.com>
@rishi-jat
rishi-jat requested a review from a team as a code owner March 16, 2026 00:14
Copilot AI review requested due to automatic review settings March 16, 2026 00:14
@rishi-jat

Copy link
Copy Markdown
Contributor Author

/cc @degenaro
/cc @vikas-agarwal76

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated cis-xlsx-to-oscal-catalog task (and its supporting artifacts) because CIS Benchmarks should be represented as OSCAL Component Definitions, with cis-xlsx-to-oscal-cd being the correct replacement (per #1811).

Changes:

  • Removed the cis-xlsx-to-oscal-catalog task implementation.
  • Removed associated unit tests, configs, and XLSX test fixtures.
  • Removed generated API reference documentation for the removed task module.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
trestle/tasks/cis_xlsx_to_oscal_catalog.py Deletes the task implementation (breaking removal).
tests/trestle/tasks/cis_xlsx_to_oscal_catalog_test.py Deletes unit tests covering the removed task.
tests/data/tasks/cis-xlsx-to-oscal-catalog/test-cis-xlsx-to-oscal-catalog.rhel.config Deletes task test config (RHEL).
tests/data/tasks/cis-xlsx-to-oscal-catalog/test-cis-xlsx-to-oscal-catalog.ocp.config Deletes task test config (OCP).
tests/data/tasks/cis-xlsx-to-oscal-catalog/CIS_Red_Hat_Enterprise_Linux_8_Benchmark_v2.0.0.snippet.xlsx Deletes XLSX fixture used by removed task/tests.
tests/data/tasks/cis-xlsx-to-oscal-catalog/CIS_RedHat_OpenShift_Container_Platform_Benchmark_v1.2.0-2.snippet.xlsx Deletes XLSX fixture used by removed task/tests.
docs/reference/API/trestle/tasks/cis_xlsx_to_oscal_catalog.md Removes API reference page for the deleted module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vikas-agarwal76

Copy link
Copy Markdown
Member

@rishi-jat We are deferring this for now. There are some discussions happening with CIS team on this. Once we have a clearer picture we will decide on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove trestle task cis-xlsx-to-oscal-catalog

3 participants