feat!: remove cis-xlsx-to-oscal-catalog task - #2156
Open
rishi-jat wants to merge 1 commit into
Open
Conversation
BREAKING CHANGE: Removed cis-xlsx-to-oscal-catalog task. Use cis-xlsx-to-oscal-cd instead. Signed-off-by: Rishi Jat <rishijat098@gmail.com>
Contributor
Author
|
/cc @degenaro |
11 tasks
There was a problem hiding this comment.
Pull request overview
Removes the deprecated cis-xlsx-to-oscal-catalog task (and its supporting artifacts) because CIS Benchmarks should be represented as OSCAL Component Definitions, with cis-xlsx-to-oscal-cd being the correct replacement (per #1811).
Changes:
- Removed the
cis-xlsx-to-oscal-catalogtask implementation. - Removed associated unit tests, configs, and XLSX test fixtures.
- Removed generated API reference documentation for the removed task module.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| trestle/tasks/cis_xlsx_to_oscal_catalog.py | Deletes the task implementation (breaking removal). |
| tests/trestle/tasks/cis_xlsx_to_oscal_catalog_test.py | Deletes unit tests covering the removed task. |
| tests/data/tasks/cis-xlsx-to-oscal-catalog/test-cis-xlsx-to-oscal-catalog.rhel.config | Deletes task test config (RHEL). |
| tests/data/tasks/cis-xlsx-to-oscal-catalog/test-cis-xlsx-to-oscal-catalog.ocp.config | Deletes task test config (OCP). |
| tests/data/tasks/cis-xlsx-to-oscal-catalog/CIS_Red_Hat_Enterprise_Linux_8_Benchmark_v2.0.0.snippet.xlsx | Deletes XLSX fixture used by removed task/tests. |
| tests/data/tasks/cis-xlsx-to-oscal-catalog/CIS_RedHat_OpenShift_Container_Platform_Benchmark_v1.2.0-2.snippet.xlsx | Deletes XLSX fixture used by removed task/tests. |
| docs/reference/API/trestle/tasks/cis_xlsx_to_oscal_catalog.md | Removes API reference page for the deleted module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@rishi-jat We are deferring this for now. There are some discussions happening with CIS team on this. Once we have a clearer picture we will decide on this. |
degenaro
force-pushed
the
develop
branch
2 times, most recently
from
August 7, 2026 11:15
64cc98c to
4fa5f11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
develop->main)Quality assurance (all should be covered).
Summary
Closes #1811
This PR removes the
cis-xlsx-to-oscal-catalogtask.As discussed in the issue, this task incorrectly transformed CIS Benchmarks into OSCAL Catalogs. Since CIS Benchmarks represent OSCAL Component Definitions, the correct task to use is
cis-xlsx-to-oscal-cd.Changes Included
trestle/tasks/cis_xlsx_to_oscal_catalog.py)This is a breaking change intended for the v4 release per the guidance in issue #1811.