chore(model): Consistently make comments for reasons optional - #11643
chore(model): Consistently make comments for reasons optional#11643sschuberth wants to merge 1 commit into
Conversation
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11643 +/- ##
============================================
- Coverage 58.39% 58.37% -0.02%
Complexity 1759 1759
============================================
Files 355 355
Lines 13204 13207 +3
Branches 1307 1307
============================================
Hits 7710 7710
- Misses 5007 5010 +3
Partials 487 487
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| * An optional comment to further explain why the [reason] is applicable here. | ||
| */ | ||
| val comment: String? = null | ||
| val comment: String = "" |
There was a problem hiding this comment.
This is a breaking change if the class is used for deserialization of config files.
| * An optional comment to further explain why the [reason] is applicable here. | ||
| */ | ||
| val comment: String | ||
| val comment: String = "" |
There was a problem hiding this comment.
IIRC it was on purpose that resolution comments must be set, even though it was not verified that they are not empty. Changing that should be explained in the commit message and I think docs should also be updates (for example, make clear that comments are optional in the resolution docs).
2 participants
No description provided.