cli-helper: Respect VCS paths in package configs - #12374
Open
CAOShurong wants to merge 1 commit into
Open
Conversation
CAOShurong
force-pushed
the
codex/ort-8713-vcs-path
branch
2 times, most recently
from
August 29, 2026 22:47
7b9114b to
c6e7244
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12374 +/- ##
============================================
+ Coverage 59.12% 59.32% +0.20%
- Complexity 1880 1894 +14
============================================
Files 365 365
Lines 13803 13811 +8
Branches 1440 1442 +2
============================================
+ Hits 8161 8194 +33
+ Misses 5112 5073 -39
- Partials 530 544 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sschuberth
reviewed
Aug 30, 2026
Filter stored scan results by the package's processed VCS path before generating path excludes so curations added after scanning are respected. Preserve existing behavior when no ORT result is provided. Fixes oss-review-toolkit#8713. Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
CAOShurong
force-pushed
the
codex/ort-8713-vcs-path
branch
from
August 30, 2026 08:58
c6e7244 to
8dc81fe
Compare
sschuberth
enabled auto-merge (rebase)
August 30, 2026 09:07
fviernau
requested changes
Aug 31, 2026
| ).convert { Identifier(it) } | ||
| .required() | ||
|
|
||
| private val ortFile by option( |
Member
There was a problem hiding this comment.
There was a reason to not read an entire OrtFile, when this command was implemented, which still is valid, which is execution performance. E.g. I believe generating a package config should be fast.
Reading an OrtFile makes it much slower.
Question: Could the VCS path also be obtained from the scan results inside scanResultsStorageDir ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ort-fileinput topackage-configuration createReproduction
With the evaluation result attached to #8713, current
maingenerated nine path excludes, including paths from unrelated Logback modules. Passing the same result with this change generates only the two expectedlogback-classicexcludes.The
orthw-shellwrapper already retains the scan result used to initialize a workspace. A follow-up there can pass that file through once this CLI option is available.Verification
./gradlew --no-configuration-cache :cli-helper:test :cli-helper:funTest :cli-helper:detektvcsProcessed.pathcuration--ort-file: the original nine-exclude behavior is unchangedFixes #8713.
AI assistance was used to inspect the code and draft the patch. The reproduction, implementation, and tests were reviewed and run locally.