Repository navigation
fix(android/camera): call Kotlin setters explicitly so auto scan works on napi runtime - #744
Merged
Merged
Conversation
…s on napi runtime Property assignment on Kotlin objects is a silent no-op on the quickjs-ng napi runtime (reads work), so the auto scan handler was never wired to the processor. Use set<Name>() on Android, keep property assignment on iOS. Refs #740 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processor.autoScanHandler = handlerandhandler.enabled = …were silent no-ops and the handler was never wired.Camera.sveltenow goes through a localsetNativePropertyhelper:set<Name>()on Android, plain property assignment on iOS (unchanged behavior).Testing
yarn svelte-check/ eslint not run (tooling not installed in the dev checkout). iOS not tested (code path unchanged).plugin-nativeprocessor/CropView.tsassignscolors/fillPaintthe same way on Android and may be affected; left out of this PR.Refs #740