Commit dacdc02
committed
docs(xml): clarify Get/GetByNamespace docs; annotate InternalsVisibleTo
The XML doc summaries on MTConnectVersion.Get and .GetByNamespace were
verbatim copies of each other, obscuring the actual contract: Get takes
a raw XML document (delegating to Namespaces.Get for the extraction
step), GetByNamespace takes an already-resolved namespace URI. Rewrite
each summary to state its own signature and mention the Max-fallback
behavior on GetByNamespace.
Annotate the InternalsVisibleTo grant in MTConnect.NET-XML.csproj so a
future reader sees why the library reaches into MTConnect.NET-XML-Tests
(the tests reach the internal MTConnectVersion / Namespaces helpers,
which have no public equivalent). Also tighten the trailing newline of
MTConnectVersion.cs and update two comment breaks in the test file to
tight em-dashes.
Ultrareview findings F-SIMP-003, F-CR-002, F-CR-004, F-CR-006 (LOW/NIT).1 parent d25c20b commit dacdc02
2 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
0 commit comments