Repository navigation
ci: retry rate-limited Conan downloads in the Windows jobs - #403
Conversation
The lmdb sources come from git.openldap.org, which answers CI runners with HTTP 429; Conan gives up after its default 2 retries 5 seconds apart.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Select Windows runner .github/workflows/test_new.yml |
The Windows job changes its runner from windows-2025 to windows-2022. |
Configure Conan download retries .github/workflows/test.yml, .github/workflows/test_new.yml |
Both workflows set Conan’s download retry count to 10 and the wait between retries to 30 seconds. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related issues
- owasp-modsecurity/ModSecurity#3604: The runner change avoids the
windows-2025failure described in the issue for thetest_new.ymlWindows job.
Possibly related PRs
- owasp-modsecurity/ModSecurity-nginx#389: Adds retry logic for direct downloads in Windows CI; this PR configures retries for Conan downloads.
Suggested reviewers: fzipi, easton97-jens
Merge Risk: 
Minimal · up to 52768
-
The workflows configure Conan retries correctly, and the Windows runner change has no demonstrated compatibility issue.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title "ci: retry rate-limited Conan downloads in the Windows jobs" matches the main change. The PR adds a PowerShell step to the Windows jobs in test.yml and test_new.yml that configures Conan to retry downloads 10 times with 30 seconds between retries, which addresses HTTP 429 rate-limit failures. The title is specific and uses the conventional ci: prefix. The commit message about moving test_new.yml to windows-2022 is a secondary change that the title does not mention, which is acceptable because the title does not need to cover every detail.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
windows-2025 now ships Visual Studio 2026 and CMake 4. With MSVC 19.5x Conan has no prebuilt binaries and builds yajl from source, whose configure step fails on CMP0026 (owasp-modsecurity/ModSecurity#3604).
|



what
test_new.ymlandtest.yml: 10 retries, 30 seconds apart, set in Conan'sglobal.confright afterconan profile detect.test_new.ymlonwindows-2022instead ofwindows-2025(see below).why
The Windows jobs build libModSecurity's dependencies with Conan, and those without a prebuilt binary are built from source. The lmdb sources come from
git.openldap.org, which answers CI runners with HTTP 429, and Conan gives up after its default 2 retries 5 seconds apart:Since about 2026-10-22 this fails all three Windows jobs on most runs, including
master(e.g. https://github.com/owasp-modsecurity/ModSecurity-nginx/actions/runs/40110043295), whatever the PR changes.second commit: run the
test_new.ymlWindows jobs onwindows-2022With the retries in place, the
windows-nginx-*jobs get past lmdb and fail one step later, on yajl:windows-2025is now thewindows-2025-vs2026image. Its MSVC iscompiler.version=195, for which ConanCenter has no prebuilt binaries, so every dependency is built from source, with the "Visual Studio 18 2026" generator and CMake 4. yajl'sCMakeLists.txtsetsCMP0026toOLD, which CMake 4 no longer supports (owasp-modsecurity/ModSecurity#3604). The 429s had been hiding this, because lmdb failed before yajl was built.test.yml, libModSecurity's own Windows CI and its release workflow all run onwindows-2022, where yajl comes as a prebuilt binary.test.yml'sbuild-windowsjob passed on this PR. The second commit moves thetest_new.ymlWindows jobs towindows-2022too, until libModSecurity builds with VS 2026 and CMake 4.notes
wgetdownloads of pcre2, zlib and OpenSSL in the step before; this one covers the dependencies Conan downloads.WITH_LMDBis off), butbuild/win32/conanfile.txtalways requires it. Making it optional there would remove the download altogether; that belongs in the ModSecurity repository.AI disclosure:
Made with help of Claude Code, Opus 5.5.
Summary by CodeRabbit