fix: wrap BadZipFile and FileNotFoundError in library exceptions (#5)

unpack_document now raises InvalidDocumentError for corrupt .docx files
and DocumentNotFoundError for missing files, instead of leaking
zipfile.BadZipFile and FileNotFoundError.

Closes #4

Author: pablospe

docx_editor/ooxml/unpack.py

@@ -6,6 +6,8 @@
 
 import defusedxml.minidom
 
+from docx_editor.exceptions import DocumentNotFoundError, InvalidDocumentError
+
 
 def unpack_document(input_file: str | Path, output_dir: str | Path) -> str:
     """Unpack a .docx file to a directory with pretty-printed XML.
@@ -18,18 +20,21 @@ def unpack_document(input_file: str | Path, output_dir: str | Path) -> str:
         str: Suggested RSID for edit session (8-character hex string)
 
     Raises:
-        FileNotFoundError: If the input file doesn't exist
-        zipfile.BadZipFile: If the file is not a valid zip/docx
+        DocumentNotFoundError: If the input file doesn't exist
+        InvalidDocumentError: If the file is not a valid zip/docx
     """
     input_path = Path(input_file)
     output_path = Path(output_dir)
 
     if not input_path.exists():
-        raise FileNotFoundError(f"Document not found: {input_file}")
+        raise DocumentNotFoundError(f"Document not found: {input_file}")
 
     # Extract and format
     output_path.mkdir(parents=True, exist_ok=True)
-    zipfile.ZipFile(input_path).extractall(output_path)
+    try:
+        zipfile.ZipFile(input_path).extractall(output_path)
+    except zipfile.BadZipFile as e:
+        raise InvalidDocumentError(f"Not a valid .docx file: {input_file}") from e
 
     # Pretty print all XML files
     xml_files = list(output_path.rglob("*.xml")) + list(output_path.rglob("*.rels"))

tests/test_ooxml.py

@@ -2,6 +2,7 @@
 
 import pytest
 
+from docx_editor.exceptions import DocumentNotFoundError, InvalidDocumentError
 from docx_editor.ooxml.pack import pack_document
 from docx_editor.ooxml.unpack import unpack_document
 
@@ -11,17 +12,15 @@ class TestUnpack:
 
     def test_unpack_nonexistent_file(self, temp_dir):
         """Test error when unpacking nonexistent file."""
-        with pytest.raises(FileNotFoundError, match="Document not found"):
+        with pytest.raises(DocumentNotFoundError, match="Document not found"):
             unpack_document(temp_dir / "nonexistent.docx", temp_dir / "output")
 
     def test_unpack_invalid_zip(self, temp_dir):
         """Test error when unpacking invalid zip file."""
-        import zipfile
-
         invalid_file = temp_dir / "invalid.docx"
         invalid_file.write_text("not a zip file")
 
-        with pytest.raises(zipfile.BadZipFile):
+        with pytest.raises(InvalidDocumentError, match="Not a valid .docx file"):
             unpack_document(invalid_file, temp_dir / "output")
 
     def test_unpack_returns_rsid(self, simple_docx, temp_dir):