Repository navigation
Commit 46aad5b
committed
docs: correct the duplicate-w:id guidance and sync docs/api.md
The per-id caveat advised falling back to the row's group_id, which is exactly
what a duplicated id does not have: _reconstruct_groups bars every occurrence
from grouping, as this PR's own TestGroupResolutionWithDuplicateIds asserts.
Two rows sharing an id in list_revisions() is the signal instead, and the
author-filtered bulk calls are the way to resolve them.
docs/api.md carried neither the author-scoping guarantee nor the per-id
caveat; its accept_all/reject_all/accept_revision/reject_revision sections now
match SKILL.md, as every prior change to this prose has kept them.
ROADMAP #75 no longer describes the fixed behaviour as current, and records
why the w:id index was scoped by author instead of the filed element-identity
suggestion. #83's fix direction named _reconstruct_groups as the sole writer
of an explicit None group; _adopt_split_tail also writes one for an
unambiguous split tail, so it points at the duplicate_ids set instead.
has_own_revisions says why it keeps the raw w:author rather than
_revision_author: an editor named "Unknown" must not claim unattributed marks.1 parent 4f8ec96 commit 46aad5b
3 files changed
Lines changed: 23 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
867 | 867 | | |
868 | 868 | | |
869 | 869 | | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
870 | 878 | | |
871 | 879 | | |
872 | 880 | | |
| |||
892 | 900 | | |
893 | 901 | | |
894 | 902 | | |
895 | | - | |
| 903 | + | |
| 904 | + | |
896 | 905 | | |
897 | 906 | | |
898 | 907 | | |
| |||
1080 | 1089 | | |
1081 | 1090 | | |
1082 | 1091 | | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
1083 | 1097 | | |
1084 | 1098 | | |
1085 | 1099 | | |
| |||
1109 | 1123 | | |
1110 | 1124 | | |
1111 | 1125 | | |
1112 | | - | |
| 1126 | + | |
| 1127 | + | |
1113 | 1128 | | |
1114 | 1129 | | |
1115 | 1130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
682 | 682 | | |
683 | 683 | | |
684 | 684 | | |
685 | | - | |
686 | | - | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
687 | 689 | | |
688 | 690 | | |
689 | 691 | | |
| |||
0 commit comments