Skip to content

refactor: move the insert and paragraph-split methods into a RevisionManager mixin (ROADMAP.md #73) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablospe merged 2 commits into from
Aug 30, 2026
Merged

refactor: move the insert and paragraph-split methods into a RevisionManager mixin (ROADMAP.md #73) #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d1c5cf
refactor: move the insert and paragraph-split methods into a Revision…
pablospe Aug 30, 2026
b82e6e3
test: cover the insert edge cases moved in ROADMAP.md #73 step 7
pablospe Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docx_editor/track_changes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,9 @@ def _ins_identity_attrs(self, ins_elem) -> str:

def _adopt_split_tail(self, original_ins, new_nodes) -> None:
raise NotImplementedError

def _rewrite_insert_at(self, paragraph, text_map: TextMap, char_pos: int, text: str) -> None:
raise NotImplementedError

def _split_foreign_ins_at(self, edge_node, offset: int) -> Element | None:
raise NotImplementedError
Loading
Loading