fix: handle Node.js 25+ where window is defined in SSR context - #390
Closed
CodeLine9 wants to merge 1 commit into
Closed
fix: handle Node.js 25+ where window is defined in SSR context#390CodeLine9 wants to merge 1 commit into
CodeLine9 wants to merge 1 commit into
Conversation
Author
|
Closing — no longer pursuing contributions here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Node.js 25 ships an experimental Web Storage API where
windowis aliased toglobalThis. This meanstypeof window === 'undefined'returnsfalseon the server, breaking the SSR guard inisServer. The library then tries to calllocalStorage.getItem()in a server context where it's not fully implemented, causingTypeError: localStorage.getItem is not a function.Fix
Add
typeof document === 'undefined'to theisServercheck.documentis only available in browser environments, not in Node.js even whenwindowis polyfilled. Also useisServerconsistently for the nonce attribute instead of re-checkingtypeof window.Closes #389