[next-themes] Declare optional React type peer - #398
Open
sharmila-oai wants to merge 1 commit into
Open
Conversation
3 tasks
sharmila-oai
marked this pull request as ready for review
August 21, 2026 22:10
Author
|
@pacocoursey could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declare
@types/reactas an optional peer dependency. The published declarations reference React types, so package managers need this relationship to resolve the consumer's installed types. Keeping the peer optional avoids requiring type packages for JavaScript-only consumers.This fixes lost callback typing with pnpm's global virtual store. With pnpm 11.19.0, next-themes 0.4.6, React 18.3.1,
@types/react18.3.3, and TypeScript 5.5.4, this consumer reports TS7006 without the peer declaration:Only the peer declaration and its workspace lockfile entry change.
Verification
packageExtensions.