Conversation
Contributor
Author
|
Crested a discussion here about requesting the feature in shairport sync. |
Owner
|
Thanks, let's hold on until we get feedback. |
Owner
|
Did you get any feedback on this? |
mill1000
force-pushed
the
feature/volume_mute
branch
from
September 13, 2024 19:38
f9a3ad4 to
dfd44be
Compare
Contributor
Author
|
I went ahead and implemented a quick PR for this: mikebrady/shairport-sync#1902 It should let us subscribe to the volume topic and use the special value of |
… determine mute state for is_volume_muted
Contributor
Author
|
Alright just updated this PR to include a check for the mute state. Haven't run any tests yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving this one as a draft for now. The mute function works but there's not feedback from Shairport on the mute state. Without feedback the local state could get out of sync. I plan to make an issue for Shairport to see if this can be solved.