Add support for volume level - #28
Open
DestruktorGitHub wants to merge 4 commits into
Open
DestruktorGitHub wants to merge 4 commits into
DestruktorGitHub wants to merge 4 commits into
Conversation
A minor fix that prevents an error from being displayed when the user tries to use the slider.
|
This looks like it would close: #27 too. Just tested it on my setup and at first glance it appears to work. Nice! Although I imagine it's going to confuse people when setting the volume via HA doesn't work so some documentation might be needed 😄 |
Owner
|
Thank you for the PR!
Agreed. Please also bump the version. |
Author
|
Okay, I added a Polish translation for the config flow, changed the README file to explain the current situation (why remote control from HA is currently not working), and listed the new features in the CHANGELOG file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also tried to implement the ability to set the volume level, but it turned out that this is no longer supported in newer versions of iOS, so I left only the functions responsible for displaying the current Airplay volume, which may make the code look a little messy.