Merge branch 'master' into vesting-genesis-fix

Author: rockbmb

.github/workflows/review-trigger.yml

@@ -38,15 +38,29 @@ jobs:
           github.event.pull_request.author_association != 'CONTRIBUTOR' && 
           github.event.pull_request.author_association != 'MEMBER'
         run: |
-          echo "User's association is ${{ github.event.pull_request.author_association }}"
           # We get the list of reviewers who approved the PR
           REVIEWERS=$(gh api repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews \
           --jq '{reviewers: [.[] | select(.state == "APPROVED") | .user.login]}')
 
-          # We request them to review again
-          echo $REVIEWERS | gh api --method POST repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/requested_reviewers --input -
+          # We request them to review again.
+          echo $REVIEWERS | gh api --silent --method POST repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/requested_reviewers --input -
 
-          echo "::error::Project needs to be reviewed again"
+          APPROVERS=$(echo "$REVIEWERS" | jq -r '.reviewers | map("@" + .) | join(", ")')
+
+          tee -a "$GITHUB_STEP_SUMMARY" <<EOF
+          ## Review required
+
+          **What failed:** @${{ github.event.pull_request.user.login }} (association \`${{ github.event.pull_request.author_association }}\`)
+          pushed \`${{ github.event.pull_request.head.sha }}\` after this pull request was already approved.
+          An approval only covers the code it was given for, so a push from an author outside the
+          organisation invalidates it.
+
+          **What needs to be done:** review has been re-requested from ${APPROVERS}.
+          Once a new approval lands, this workflow re-runs and the check passes.
+          The author does not need to change anything.
+          EOF
+
+          echo "::error title=Review required::Author pushed new commits after approval, a new approval from ${APPROVERS} is needed"
           exit 1
         env:
           GH_TOKEN: ${{ github.token }}

.github/workflows/vertex-ai-review.yml

@@ -0,0 +1,32 @@
+name: Vertex AI Review
+
+# Comment "/aireview" on a pull request to get a review from Vertex AI (Gemini).
+# The reviewer reads the diff over the GitHub API and never checks out or runs
+# code from the pull request, which is what makes it safe to hold credentials
+# while reviewing a fork.
+#
+# Only a MEMBER, an OWNER or a COLLABORATOR can trigger it.
+
+on:
+  issue_comment:
+    types: [created]
+
+permissions: {}
+
+concurrency:
+  group: vertex-ai-review-${{ github.event.issue.number }}
+  cancel-in-progress: true
+
+jobs:
+  review:
+    permissions:
+      contents: read
+      pull-requests: write
+      id-token: write
+    uses: paritytech/ci-actions-public/.github/workflows/vertex-ai-review.yaml@main # zizmor: ignore[unpinned-uses]
+    with:
+      vertex_project: ${{ vars.VERTEX_PROJECT }}
+      comment_trigger: "/aireview"
+    secrets:
+      GCP_SA_VERTEX_AI_REVIEW: ${{ secrets.GCP_SA_VERTEX_AI_REVIEW }}
+      GCP_WIP_VERTEX_AI_REVIEW: ${{ secrets.GCP_WIP_VERTEX_AI_REVIEW }}

.github/zombienet-tests/zombienet_polkadot_tests.yml

@@ -234,8 +234,20 @@
   use-zombienet-sdk: true
   cumulus-image: "test-parachain"
 
-- job-name: "zombienet-polkadot-scheduling-v3-dynamic-enablement"
-  test-filter: "functional::v3_dynamic_enablement::v3_dynamic_enablement_test"
+- job-name: "zombienet-polkadot-scheduling-v3-dynamic-enablement-para-rollback"
+  test-filter: "functional::v3_dynamic_enablement::v3_dynamic_enablement_test::case_1_para_rollback"
+  runner-type: "large"
+  use-zombienet-sdk: true
+  cumulus-image: "test-parachain"
+
+- job-name: "zombienet-polkadot-scheduling-v3-dynamic-enablement-para-rollback-rpo-2"
+  test-filter: "functional::v3_dynamic_enablement::v3_dynamic_enablement_test::case_2_para_rollback_rpo_2"
+  runner-type: "large"
+  use-zombienet-sdk: true
+  cumulus-image: "test-parachain"
+
+- job-name: "zombienet-polkadot-v4-collation-protocol-version-negotiation"
+  test-filter: "functional::collation_protocol_version_negotiation::collation_protocol_version_negotiation"
   runner-type: "default"
   use-zombienet-sdk: true
   cumulus-image: "test-parachain"