Repository navigation
refactor: Bump eslint from 10.7.0 to 10.13.0 - #305
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 34 minutes. View limit details
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 159 159
=========================================
Hits 159 159 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Bumps eslint from 10.7.0 to 10.13.0 (dev dependency, exact-pinned).
Closes #301
Dependabot opened #301 for 10.12.0 and retargeted it to 10.13.0 on 2026-10-24; this PR pins exactly that target.
@eslint/jsstays at10.0.1, which is its latest release and has the peer rangeeslint: ^10.0.0. The Node requirement (^20.19.0 || ^22.13.0 || >=24) is the same for every version from 10.7.0 to 10.13.0.Changes
10.8.0
ConfigObjectfromeslint/config(feat: exportConfigObjectfromeslint/configeslint/eslint#21082)htmlformatter (fix: escape reserved characters in rule id inhtmlformatter eslint/eslint#21129)no-unreachable-loopcrash when all loop types are ignored (fix: preventno-unreachable-loopcrash when all loop types are ignored eslint/eslint#21116)prefer-object-spreadadds semicolon when adding parenthesis (fix: prefer-object-spread add semicolon when adding parenthesis eslint/eslint#21081)prefer-template(fix: quadratic-time regex inprefer-templateeslint/eslint#21096)class-methods-use-this(fix: apply ignore configs to computed methods in class-methods-use-this eslint/eslint#21094)NewExpressionwith parenthesized callee inpreserve-caught-error(fix: NewExpression with parenthesized callee inpreserve-caught-erroreslint/eslint#21083)minimatchrange raised to^10.2.5(chore: update minimatch to ^10.2.5 eslint/eslint#21107),@eslint/config-helpersrange raised to^0.7.010.8.1
no-unused-labelsautofix (fix: prevent ASI hazard inno-unused-labelsautofix eslint/eslint#21173)getter-returnandaccessor-pairs(fix: false positives ingetter-returnandaccessor-pairseslint/eslint#21163)id-denylist(fix: ignore meta-property names inid-denylisteslint/eslint#21166)id-match(fix: ignore meta-property names inid-matcheslint/eslint#21167)no-unused-varsremoveVar suggestion (fix: handle ASI hazards in no-unused-vars removeVar suggestion eslint/eslint#20935)10.9.0
no-loss-of-precision(feat: handle underflow in no-loss-of-precision eslint/eslint#21218)checkConditionalExpressionsoption tono-unmodified-loop-condition(feat: add checkConditionalExpressions tono-unmodified-loop-conditioneslint/eslint#21175)no-varautofix with hoisted functions (fix: prevent unsafeno-varautofix with hoisted functions eslint/eslint#21213)no-varautofix when the variable is shadowed by a catch parameter (fix: Prevent no-var autofix when var is shadowed by catch parameter eslint/eslint#21204)prefer-templateinvalid autofix creates a tagged template call (fix: prefer-template invalid autofix creates a tagged template call eslint/eslint#21207)10.9.1
no-loss-of-precisionfalse positive with trailing decimal point (fix: no-loss-of-precision false positive with trailing decimal point eslint/eslint#21251)10.10.0
dandvflags tono-unexpected-multiline(feat: adddandvflags tono-unexpected-multilineeslint/eslint#21305)Object.prototypeproperty names innew-cap(feat: checkObject.prototypeproperty names innew-capeslint/eslint#21269)no-extra-bindfalse negatives with class fields and static blocks (feat: no-extra-bind false negatives with class fields and static blocks eslint/eslint#21260)file-entry-cacheto v11 (fix: update dependency file-entry-cache to v11 eslint/eslint#20801)__proto__in/* exported */comments (fix: support__proto__in/* exported */comments eslint/eslint#21261)prefer-object-has-ownautofix breaks whenObjectis shadowed (fix: prefer-object-has-own autofix breaks when Object is shadowed eslint/eslint#21282)new-capfalse positive forUTCcalls withproperties: false(fix:new-capfalse positive forUTCcalls withproperties: falseeslint/eslint#21275)no-unreachable(fix: Ignore static imports in no-unreachable eslint/eslint#21276)@eslint/plugin-kitrange raised to^0.7.310.11.0
object-shorthandhandles quoted properties forignoreConstructors(feat: object-shorthand handle quoted properties forignoreConstructorseslint/eslint#21271)continueinno-unsafe-finally(feat: report unsafe labeledcontinueinno-unsafe-finallyrule eslint/eslint#21316)new-capbuilt-ins that reference the global (feat: only exemptnew-capbuilt-ins that reference the global eslint/eslint#21290)__proto__properties inprefer-object-spread(fix: ignore__proto__properties inprefer-object-spreadeslint/eslint#21311)TimePass.parseoptional in types and docs (fix: make TimePass.parse optional in types and docs eslint/eslint#21313)__proto__properties inobject-shorthand(fix: don't report__proto__properties inobject-shorthandeslint/eslint#21310)10.12.0
new-cap(feat: handle astral letters innew-capeslint/eslint#21357)SourceCode#getText()to accept tokens and comments (feat: allowSourceCode#getText()to accept tokens and comments eslint/eslint#21340)prefer-arrow-callbackfalse positive in conditional test (fix:prefer-arrow-callbackfalse positive in conditional test eslint/eslint#21373)max-lines-per-function(fix: skip lines with multiple comments inmax-lines-per-functioneslint/eslint#21332)consistent-return,no-eval,no-invalid-this(fix: astral letters inconsistent-return,no-eval,no-invalid-thiseslint/eslint#21360)prefer-exponentiation-operatorautofix for async function base (fix: prefer-exponentiation-operator autofix for async function base eslint/eslint#21322)elseincurlyautofix (fix: add missing space afterelseincurlyautofix eslint/eslint#21355)id-lengthmessage for long private names (fix: correctid-lengthmessage for long private names eslint/eslint#21348)TSFunctionTypeingetFunctionHeadLoc(fix: supportTSFunctionTypeingetFunctionHeadLoceslint/eslint#21335)no-loss-of-precisionfalse positive with0.e5(fix:no-loss-of-precisionfalse positive with0.e5eslint/eslint#21337)languageOptions(perf: cache normalized config globals per languageOptions eslint/eslint#21364)10.13.0
no-use-before-define(feat: report references inside IIFEs inno-use-before-defineeslint/eslint#21238)globalThistono-obj-calls(feat: addglobalThistono-obj-callseslint/eslint#21382)yield*expressions inno-unsafe-optional-chaining(feat: checkyield*expressions inno-unsafe-optional-chainingeslint/eslint#21399)letwhenno-varandone-varfix together (fix: avoid redeclaredletwhenno-varandone-varfix together eslint/eslint#21389)no-redeclarescan for single-declaration variables (perf: skip no-redeclare scan for single-declaration variables eslint/eslint#21365)Impact on this project
The effective lint config (
eslint.config.mjs) isjs.configs.recommendedfrom@eslint/js10.0.1 withno-useless-escapeandrequire-atomic-updatesturned off, plusindent,linebreak-style,no-trailing-spaces,eol-last,space-in-parens,no-multiple-empty-lines,prefer-constandspace-infix-ops.Changed rules that are enabled here, all through
recommended:preserve-caught-error(10.8.0 fix)getter-return(10.8.1 false-positive fix, fix: false positives ingetter-returnandaccessor-pairseslint/eslint#21163)no-setter-return(10.8.1, logic moved to a shared helper in fix: false positives ingetter-returnandaccessor-pairseslint/eslint#21163 with no listed behavior change)no-unused-labels(10.8.1, autofix only)no-unused-vars(10.8.1, suggestion only)no-loss-of-precision(10.9.0 underflow detection, 10.9.1 and 10.12.0 false-positive fixes)no-unexpected-multiline(10.10.0d/vflags)no-unreachable(10.10.0 static imports ignored)no-unsafe-finally(10.11.0 labeledcontinue)no-obj-calls(10.13.0globalThis)no-unsafe-optional-chaining(10.13.0yield*)no-redeclare(10.13.0 performance only)The 10.8.1 and 10.9.1 changes to these rules only remove false positives or fix autofixes and suggestions. The changed rules not listed here (e.g.
accessor-pairs,id-denylist,id-match,no-var,prefer-template,new-cap,object-shorthand,curly,no-use-before-define,one-var) are not enabled. The/* exported */fix only applies to script source type, and this project lints assourceType: "module". Thefile-entry-cachev11 update only affects--cache, whichnpm run lintdoesn't use. The Lint CI job validates that the new detections report no violations.Lock file:
eslint10.7.0 → 10.13.0,@eslint/config-helpers0.6.0 → 0.7.0,@eslint/plugin-kit0.7.2 → 0.7.3,minimatch10.2.4 → 10.2.6, and thefile-entry-cache8.0.0 → 11.1.5 subtree (flat-cache4.0.1 → 6.1.23,flatted3.4.2 → 3.4.4,keyv4.5.4 → 5.6.0,json-bufferremoved,cacheable,@cacheable/memory,@cacheable/utils,@keyv/bigmap,@keyv/serialize,hashery,hookified,qifiedadded). All entries are dev-only.The hoisted
minimatch10.2.4 → 10.2.6 comes from eslint's own^10.2.5range. Other dev tools also use it:@eslint/config-array,test-exclude, and theglobcopies underjasmine,nyc,rimrafandtest-exclude. Its only behavior change is Windows-only (isaacs/minimatch@7953af1,..no longer consumes a drive letter). All Tests jobs pass.Breaking Changes
None
Code Changes Required
None. The upgrade is a drop-in replacement; only
package.jsonandpackage-lock.jsonchanged.