Skip to content

Commit 5c71f20

Browse files
committed
chore: remove API key tests
1 parent 5dfffc8 commit 5c71f20

2 files changed

Lines changed: 0 additions & 55 deletions

File tree

‎src/apikeys.rs‎

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -113,31 +113,3 @@ impl actix_web::ResponseError for ApiKeyError {
113113
}
114114
}
115115
}
116-
117-
#[cfg(test)]
118-
mod request_tests {
119-
use super::{ApiKeyType, CreateApiKeyRequest};
120-
121-
#[test]
122-
fn typed_keys_and_existing_role_requests_deserialize() {
123-
let ingestor: CreateApiKeyRequest =
124-
serde_json::from_str(r#"{"keyName":"ingest-key","apiKeyType":"ingestor"}"#).unwrap();
125-
assert_eq!(ingestor.api_key_type, Some(ApiKeyType::Ingestor));
126-
127-
let query: CreateApiKeyRequest =
128-
serde_json::from_str(r#"{"keyName":"query-key","apiKeyType":"query"}"#).unwrap();
129-
assert_eq!(query.api_key_type, Some(ApiKeyType::Query));
130-
131-
let ui: CreateApiKeyRequest =
132-
serde_json::from_str(r#"{"keyName":"ui-key","roles":["reader-role"]}"#).unwrap();
133-
assert_eq!(ui.api_key_type, None);
134-
assert!(ui.roles.contains("reader-role"));
135-
136-
assert!(
137-
serde_json::from_str::<CreateApiKeyRequest>(
138-
r#"{"keyName":"old-key","ingestorOnly":true}"#
139-
)
140-
.is_err()
141-
);
142-
}
143-
}

‎src/rbac/mod.rs‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -428,30 +428,3 @@ pub fn roles_to_permission(roles: Vec<String>, tenant_id: &str) -> Vec<Permissio
428428
}
429429
perms.into_iter().collect()
430430
}
431-
432-
#[cfg(test)]
433-
mod global_api_key_role_tests {
434-
use super::*;
435-
436-
#[test]
437-
fn internal_ingestor_role_grants_only_global_ingest() {
438-
let permissions = roles_to_permission(vec![GLOBAL_INGESTOR_ROLE.to_string()], "tenant");
439-
assert_eq!(
440-
permissions,
441-
vec![Permission::Resource(Action::Ingest, None)]
442-
);
443-
}
444-
445-
#[test]
446-
fn internal_querier_role_has_reader_access_to_all_datasets() {
447-
let permissions = roles_to_permission(vec![GLOBAL_QUERIER_ROLE.to_string()], "tenant");
448-
let all_datasets = Some(ParseableResourceType::Stream("*".to_string()));
449-
assert!(permissions.contains(&Permission::Resource(Action::Query, all_datasets.clone())));
450-
assert!(permissions.contains(&Permission::Resource(Action::ListStream, all_datasets)));
451-
assert!(!permissions.iter().any(|permission| matches!(
452-
permission,
453-
Permission::Resource(Action::Ingest | Action::All, _)
454-
| Permission::Unit(Action::DeleteStream | Action::PutRole)
455-
)));
456-
}
457-
}

0 commit comments

Comments
 (0)