[nikhilsinhaparseable]

Summary by CodeRabbit

• New Features
  • Added support for PromQL filters.
  • PromQL filters now use dataset-based authorization, while SQL filters continue to use query-based authorization.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: 5505f11d-5f2a-4194-9213-362ad9070e7e

📥 Commits

Reviewing files that changed from the base of the PR and between a5976d2 and eec7c9f.

📒 Files selected for processing: 1

• src/users/filters.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The filter type now includes PromQL, serialized as "promql". Filter listing authorizes PromQL filters against the saved stream’s dataset. SQL filters continue to use query-based authorization.

Changes

PromQL Filter Authorization

Layer / File(s)	Summary
PromQL filter type and authorization src/users/filters.rs	Adds the Promql filter type and its "promql" serialization. Filter listing uses dataset-based authorization for PromQL, Search, and Filter types, while SQL uses query-based authorization.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: parmesant

Merge Risk: ⚪ Minimal · up to eec7c

Saved PromQL filters retain their type, and no actionable merge risk was identified. Mergeable after normal checks.

Pre-merge checks: 3 · 2

Failed checks: 2 warnings

Check name	Status	Explanation	Resolution
Description check		The pull request has no description. It omits the required Description section, issue reference handling, rationale, key changes, and validation checklist.	Add a pull request description with the goal, chosen solution and rationale, key changes, relevant issue reference or removal of the issue section, and completed testing, comments, and documentation checklist items.
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly states the main change: saving PromQL queries in filters.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{A rabbit checks each filter’s name,
PromQL joins the list in frame.
Dataset rules guide where it may go,
While SQL keeps its query flow.
The carrot queue is neat as snow.}

_{Comment @coderabbitai help to get the list of available commands.}