Skip to content

feat: save promql queries in filters #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhilsinhaparseable merged 1 commit into from
Oct 22, 2026
Merged

feat: save promql queries in filters #1830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions src/users/filters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ pub enum FilterType {
Filter,
SQL,
Search,
Promql,
}

impl FilterType {
Expand All @@ -86,6 +87,7 @@ impl FilterType {
FilterType::Filter => "filter",
FilterType::SQL => "sql",
FilterType::Search => "search",
FilterType::Promql => "promql",
}
}
}
Expand Down Expand Up @@ -179,23 +181,26 @@ impl Filters {
let query: &str = f.query.filter_query.as_deref().unwrap_or("");
let filter_type = &f.query.filter_type;

// if filter type is SQL, check if the user has access to the dataset based on the query string
// if filter type is search or filter, check if the user has access to the dataset based on the dataset name
if *filter_type == FilterType::SQL {
if (user_auth_for_query(key, query).await).is_ok() {
_filters.push(f.clone())
match filter_type {
// SQL queries can reference multiple datasets, so authorize the query itself.
FilterType::SQL => {
if (user_auth_for_query(key, query).await).is_ok() {
_filters.push(f.clone())
}
}
} else if *filter_type == FilterType::Search || *filter_type == FilterType::Filter {
let dataset_name = &f.stream_name;
if user_auth_for_datasets(
&permissions,
std::slice::from_ref(dataset_name),
&tenant_id,
)
.await
.is_ok()
{
_filters.push(f.clone())
// Other filter types are scoped by the saved filter's dataset.
FilterType::Search | FilterType::Filter | FilterType::Promql => {
let dataset_name = &f.stream_name;
if user_auth_for_datasets(
&permissions,
std::slice::from_ref(dataset_name),
&tenant_id,
)
.await
.is_ok()
{
_filters.push(f.clone())
}
}
}
}
Expand Down
Loading