Repository navigation
OpenRFID: forward additional filament colors to filament_detect - #788
Merged
paxx12 merged 2 commits intoOct 19, 2026
Merged
Conversation
The OpenRFID webhook templates only sent RGB_1, so multicolor spools (e.g. Bambu dual-color, OpenSpool `additional_color_hexes`) showed a single color when using the OpenRFID detection system, while the built-in reader already populates RGB_2..RGB_5. Send colors 2-5 from `filament.colors_rgba` as RGB_2..RGB_5 in both the vendor and generic templates. filament_detect/set already derives COLOR_NUMS from these, so filament_color_multi is populated as with the built-in reader. Single-color spools are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011NVRoJLjL7JBmLBtmjrTrv
✅ Build ArtifactsVersion:
|
RrrrobertB1992
changed the title
paxx12
reviewed
Oct 17, 2026
paxx12
requested changes
Oct 17, 2026
paxx12
left a comment
paxx12
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the changes. Please take a look at review comments.
Put the RGB_2..RGB_5 loop on its own lines instead of prefixing the CARD_UID line with the endfor tag, as requested in review. The rendered JSON is identical apart from whitespace. Made with help from Claude
✅ Build ArtifactsVersion:
|
paxx12
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the RFID Detection System set to OpenRFID, a multicolor spool shows only its first color. The
openrfid_u1_vendor.cfgandopenrfid_u1_generic.cfgwebhook templates sendRGB_1and nothing else, while the built-in reader fillsRGB_2..RGB_5, andfilament_detect/setalready accepts those fields and derivesCOLOR_NUMSfrom them.Without this change, the rainbow filament display added in stock 2.0.0.205 never receives more than one color from OpenRFID-read spools.
Changes
Both templates now emit
RGB_2..RGB_5fromfilament.colors_rgba[1:5], converting RGBA to RGB. The loop adds nothing for single-color spools, so their payload is unchanged.Affected tag formats
This forwards every color OpenRFID already parses, so multicolor display now works through OpenRFID for:
GIT_SHAin64-app-openrfid/pre-scripts/01-install-openrfid.shis bumpedGIT_SHAis bumpedSingle-color formats (Anycubic, Qidi, Creality, Elegoo) send the same payload as before.
Hardware-tested with OpenSpool. The other formats were verified by reading their OpenRFID processors, and I haven't tested them on hardware.
Testing
Tested on a U1 with this branch built on
develop(base 2.0.0.205), with suchmememanyskill/OpenRFID#37 applied on top of the pinned OpenRFID commit, OpenRFID as the detection system, and a red/blue OpenSpool tag:print_task_config.filament_color_multifor that channel:nums 2, colors["FF0000", "0000FF"]. Before this change it showednums 1.nums 1, correct colors).Images