core (util): Remove redundant trailing_ones. - #399
Merged
Conversation
velvid
changed the title
velvid
changed the title
velvid
marked this pull request as ready for review
July 30, 2025 00:40
pdeljanov
requested changes
Aug 19, 2025
pdeljanov
left a comment
pdeljanov
left a comment
Owner
There was a problem hiding this comment.
Thanks for this. We can remove these since they are now provided by Rust, but only in the dev-0.6 branch since this would be a semver-breaking change.
pdeljanov
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 1.46.0, the language natively supports trailing_ones for all primitive integer types.
The manual implementations can be removed from the bit manipulation utilities.