Query exception bug

Author: pdphilip

src/Exceptions/QueryException.php

@@ -60,6 +60,10 @@ private function routeClientResponseException($result): string
             return $this->formatAsConflictException($error);
         }
 
+        if (! isset($error['error']['type'])) {
+            return $result->getMessage();
+        }
+
         return match ($error['error']['type']) {
             'search_phase_execution_exception' => $this->formatSearchPhaseExecutionException($error),
             'script_exception' => $this->formatScriptException($error),

tests/ExceptionTest.php

@@ -19,3 +19,26 @@
 
 Root Cause Type: parsing_exception
 Root Cause Reason: Unknown key for a START_ARRAY in [query]');
+
+it('handles error responses without error.type structure', function () {
+    $body = json_encode(['status' => 400, 'message' => 'Something went wrong']);
+    $response = new \GuzzleHttp\Psr7\Response(400, [], $body);
+    $previous = new \Elastic\Elasticsearch\Exception\ClientResponseException($body, 400);
+    $previous->setResponse($response);
+
+    $exception = new QueryException($previous);
+
+    expect($exception)->toBeInstanceOf(QueryException::class)
+        ->and($exception->getMessage())->toBe($body);
+});
+
+it('handles error responses with null json body', function () {
+    $response = new \GuzzleHttp\Psr7\Response(400, [], 'not json at all');
+    $previous = new \Elastic\Elasticsearch\Exception\ClientResponseException('not json at all', 400);
+    $previous->setResponse($response);
+
+    $exception = new QueryException($previous);
+
+    expect($exception)->toBeInstanceOf(QueryException::class)
+        ->and($exception->getMessage())->toBe('not json at all');
+});