_id bug

Author: pdphilip

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to this `laravel-elasticsearch` package will be documented in this file.
 
+## v5.4.1 - 2026-02-23
+
+### Fixed
+
+- `_id` no longer leaks into serialized output (`toArray()`, `toJson()`). The internal `_id` metadata field was being exposed alongside `id`, resulting in duplicate ID fields in model serialization.
+
 ## v5.4.0 - 2026-02-21
 
 This release is compatible with Laravel 10, 11 & 12
@@ -95,7 +101,8 @@ Why: When you need IDs that sort chronologically across multiple processes/worke
 - Test suite expanded from 379 to 422 tests (2,548 assertions), all passing
 
 ### Fixed
-- `id` is now always present in serialized model output
+- `id` is now always present in serialized model output (`toArray()`, `toJson()`)
+- `_id` is no longer exposed in serialized output (internal metadata stays internal)
 - Removed dead debug code from Connection.php
 
 **Full Changelog**: https://github.com/pdphilip/laravel-elasticsearch/compare/v5.3.0...v5.4.0

src/Eloquent/ElasticsearchModel.php

@@ -105,11 +105,11 @@ public function attributesToArray(): array
     {
         $attributes = parent::attributesToArray();
 
-        // Ensure 'id' is always present in serialized output
-        // ES stores document ID as '_id', but we want 'id' for consistency
+        // ES stores document ID as '_id' metadata, but we want 'id' for consistency
         if (! isset($attributes['id'])) {
             $attributes['id'] = $this->id;
         }
+        unset($attributes['_id']);
 
         return $attributes;
     }

tests/ModelTest.php

@@ -707,25 +707,24 @@
     expect($fetched->id)->toBe($originalId)
         ->and($fetched->_id)->toBe($originalId);
 
-    // Verify toArray() includes 'id' key
+    // Verify toArray() includes 'id' but not '_id'
     $array = $fetched->toArray();
     expect($array)->toHaveKey('id')
-        ->and($array['id'])->toBe($originalId);
+        ->and($array['id'])->toBe($originalId)
+        ->and($array)->not->toHaveKey('_id');
 
-    // Both 'id' and '_id' should be present for backwards compatibility
-    expect($array)->toHaveKey('_id')
-        ->and($array['_id'])->toBe($originalId);
-
-    // Verify toJson() includes 'id' key
+    // Verify toJson() includes 'id' but not '_id'
     $json = json_decode($fetched->toJson(), true);
     expect($json)->toHaveKey('id')
-        ->and($json['id'])->toBe($originalId);
+        ->and($json['id'])->toBe($originalId)
+        ->and($json)->not->toHaveKey('_id');
 
     // Verify collection serialization also includes 'id'
     $users = User::where('name', 'John Doe')->get();
     $collectionArray = $users->toArray();
     expect($collectionArray[0])->toHaveKey('id')
-        ->and($collectionArray[0]['id'])->toBe($originalId);
+        ->and($collectionArray[0]['id'])->toBe($originalId)
+        ->and($collectionArray[0])->not->toHaveKey('_id');
 });
 
 it('tests _id is still accessible for backwards compatibility', function () {