whereFieldDoesntExist to whereNotFieldExists

Author: pdphilip

CHANGELOG.md

@@ -8,8 +8,8 @@ This release is compatible with Laravel 11, 12 & 13
 
 ### Added
 
-- **`whereNestedFieldExists($path)`** ([docs](https://elasticsearch.pdphilip.com/eloquent/nested-queries#where-nested-field-exists)) - explicit, zero-overhead check for "this nested path has at least one document." Emits the idiomatic `nested + exists` form directly, no closure required. Variants: `whereNestedFieldDoesntExist`, `orWhereNestedFieldExists`, `orWhereNestedFieldDoesntExist`.
-- **`whereFieldExists($field)`** ([docs](https://elasticsearch.pdphilip.com/eloquent/eloquent-queries#wherefieldexists)) - properly named alias for the Elasticsearch `exists` query. Variants: `whereFieldDoesntExist`, `orWhereFieldExists`, `orWhereFieldDoesntExist`.
+- **`whereNestedFieldExists($path)`** ([docs](https://elasticsearch.pdphilip.com/eloquent/nested-queries#where-nested-field-exists)) - explicit, zero-overhead check for "this nested path has at least one document." Emits the idiomatic `nested + exists` form directly, no closure required. Variants: `whereNotNestedFieldExists`, `orWhereNestedFieldExists`, `orWhereNotNestedFieldExists`.
+- **`whereFieldExists($field)`** ([docs](https://elasticsearch.pdphilip.com/eloquent/eloquent-queries#wherefieldexists)) - properly named alias for the Elasticsearch `exists` query. Variants: `whereNotFieldExists`, `orWhereFieldExists`, `orWhereNotFieldExists`.
 - **`nestedQuery($column)`** ([docs](https://elasticsearch.pdphilip.com/eloquent/nested-queries#building-the-inner-query-programmatically)) - returns a pre-configured Builder you can build up across conditionals and functions, then pass straight to `whereNestedObject()`. The closure form still works for simple cases; this is the escape hatch for programmatic composition.
 - `whereNestedObject()` now accepts a pre-built Builder (from `nestedQuery()`) in addition to a Closure or raw DSL string. Invalid input now throws `BuilderException` instead of silently being stored.
 
@@ -22,9 +22,9 @@ This release is compatible with Laravel 11, 12 & 13
 
 - **`whereTermExists` family** - replaced by `whereFieldExists`. The `Term` prefix was historical (the underlying ES query isn't term-related) and the old name avoided collision with Laravel's base `whereExists(Closure)`. Old methods still work; will be removed in v6:
     - `whereTermExists` → `whereFieldExists`
-    - `whereNotTermExists` → `whereFieldDoesntExist`
+    - `whereNotTermExists` → `whereNotFieldExists`
     - `orWhereTermExists` → `orWhereFieldExists`
-    - `orWhereNotTermsExists` → `orWhereFieldDoesntExist` (also fixes the typo'd plural "Terms")
+    - `orWhereNotTermsExists` → `orWhereNotFieldExists` (also fixes the typo'd plural "Terms")
 
 **Full Changelog**: https://github.com/pdphilip/laravel-elasticsearch/compare/v5.6.1...v5.7.0
 

src/Eloquent/Docs/ModelDocs.php

@@ -82,18 +82,18 @@
  * @method static $this orWhereNestedObject($column, $query, $filterInnerHits = false, $options = [])
  * @method static $this orWhereNotNestedObject($column, $query, $filterInnerHits = false, $options = [])
  * @method static $this whereNestedFieldExists(string $path, string $boolean = 'and', bool $not = false)
- * @method static $this whereNestedFieldDoesntExist(string $path)
+ * @method static $this whereNotNestedFieldExists(string $path)
  * @method static $this orWhereNestedFieldExists(string $path)
- * @method static $this orWhereNestedFieldDoesntExist(string $path)
+ * @method static $this orWhereNotNestedFieldExists(string $path)
  *-----------------------------------
  * @method static $this whereFieldExists($column, $boolean = 'and', $not = false)
- * @method static $this whereFieldDoesntExist($column)
+ * @method static $this whereNotFieldExists($column)
  * @method static $this orWhereFieldExists($column)
- * @method static $this orWhereFieldDoesntExist($column)
+ * @method static $this orWhereNotFieldExists($column)
  * @method static $this whereTermExists($column, $boolean = 'and', $not = false) @deprecated use whereFieldExists
- * @method static $this whereNotTermExists($column) @deprecated use whereFieldDoesntExist
+ * @method static $this whereNotTermExists($column) @deprecated use whereNotFieldExists
  * @method static $this orWhereTermExists($column) @deprecated use orWhereFieldExists
- * @method static $this orWhereNotTermsExists($column) @deprecated use orWhereFieldDoesntExist
+ * @method static $this orWhereNotTermsExists($column) @deprecated use orWhereNotFieldExists
  *-----------------------------------
  * @method static $this whereRaw($dsl, $bindings = [], $boolean = 'and', $options = [])
  *===========================================

src/Query/Concerns/BuildsFieldQueries.php

@@ -107,7 +107,7 @@ public function whereFieldExists($column, $boolean = 'and', $not = false): self
         return $this;
     }
 
-    public function whereFieldDoesntExist($column): self
+    public function whereNotFieldExists($column): self
     {
         return $this->whereFieldExists($column, 'and', true);
     }
@@ -117,7 +117,7 @@ public function orWhereFieldExists($column): self
         return $this->whereFieldExists($column, 'or', false);
     }
 
-    public function orWhereFieldDoesntExist($column): self
+    public function orWhereNotFieldExists($column): self
     {
         return $this->whereFieldExists($column, 'or', true);
     }
@@ -131,7 +131,7 @@ public function whereTermExists($column, $boolean = 'and', $not = false): self
     }
 
     /**
-     * @deprecated Use whereFieldDoesntExist() instead. Will be removed in v6.
+     * @deprecated Use whereNotFieldExists() instead. Will be removed in v6.
      */
     public function whereNotTermExists($column): self
     {
@@ -147,7 +147,7 @@ public function orWhereTermExists($column): self
     }
 
     /**
-     * @deprecated Use orWhereFieldDoesntExist() instead. Will be removed in v6.
+     * @deprecated Use orWhereNotFieldExists() instead. Will be removed in v6.
      *             Note: the original method name had a typo ("Terms" plural).
      */
     public function orWhereNotTermsExists($column): self

src/Query/Concerns/BuildsNestedQueries.php

@@ -152,7 +152,7 @@ public function whereNestedFieldExists(string $path, string $boolean = 'and', bo
         return $this;
     }
 
-    public function whereNestedFieldDoesntExist(string $path): self
+    public function whereNotNestedFieldExists(string $path): self
     {
         return $this->whereNestedFieldExists($path, 'and', true);
     }
@@ -162,7 +162,7 @@ public function orWhereNestedFieldExists(string $path): self
         return $this->whereNestedFieldExists($path, 'or', false);
     }
 
-    public function orWhereNestedFieldDoesntExist(string $path): self
+    public function orWhereNotNestedFieldExists(string $path): self
     {
         return $this->whereNestedFieldExists($path, 'or', true);
     }

tests/QueryElasticsearchSpecificTest.php

@@ -197,8 +197,8 @@
     expect(User::whereFieldExists('title')->count())->toBe(8);
 });
 
-it('whereFieldDoesntExist matches users with the field missing', function () {
-    expect(User::whereFieldDoesntExist('title')->count())->toBe(1);
+it('whereNotFieldExists matches users with the field missing', function () {
+    expect(User::whereNotFieldExists('title')->count())->toBe(1);
 });
 
 it('whereFieldExists is parity with deprecated whereTermExists', function () {
@@ -266,8 +266,8 @@
     expect(Post::whereNestedFieldExists('comments')->count())->toBe(4);
 });
 
-it('whereNestedFieldDoesntExist wraps nested inside must_not', function () {
-    $dsl = Post::whereNestedFieldDoesntExist('comments')->toDsl();
+it('whereNotNestedFieldExists wraps nested inside must_not', function () {
+    $dsl = Post::whereNotNestedFieldExists('comments')->toDsl();
 
     $mustNot = $dsl['body']['query']['bool']['must_not'][0];
     expect($mustNot)->toHaveKey('nested')