Add ES 9.x CI matrix and force_source deprecation notice - #93
Conversation
cb48e65 to
5bcc596
Compare
|
Hey @abkrim, the v8 PHP client is forward-compatible with ES 9.x servers; the constraint change isn't needed yet until v9 ships with features not in v8 that we'll need in the package itself. What's driving this on your end beyond just using the latest client? |
|
Hey @pdphilip, you're right — the v8 PHP client is forward-compatible with ES 9.x servers, so the constraint change isn't strictly necessary at this point. On my end, I've been running ES 9.0 in production and wanted to make sure the package worked cleanly against it. The full test suite (269 tests) passes without any code changes, which is great news. I'm happy to simplify this PR by dropping the
Want me to push that simplified version, or would you prefer to handle the CI update separately? |
f153ae6 to
925a6e7
Compare
abkrim
changed the title
Update PHP client constraint to ^8.17|^9.0 and CI workflow with matrix testing for both ES 8.18.0 and 9.0.0. Docker images use official docker.elastic.co registry. Mark force_source highlight parameter as deprecated (removed in ES 9.x, deprecated since 8.11). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
925a6e7 to
0c5eb3d
Compare
|
Closing this PR — after our discussion, I agree the v8 PHP client is forward-compatible with ES 9.x servers, so the constraint change isn't needed at this point. The CI matrix and |
2 participants
Summary
Rebased on v5.4.0. No changes to
composer.json— the v8 PHP client is forward-compatible with ES 9.x servers.force_sourcedeprecation: Added notice inCompilesOrders.php— this highlighting parameter was deprecated in ES 8.11 and removed in ES 9.xdocker-compose.ymlto use officialdocker.elastic.coimagesWhat was tested
Full test suite passes against both ES 8.18.0 and ES 9.0.0 without any code changes.
Test plan
./vendor/bin/pestagainst ES 9.0.0 — all tests passed, 0 failurescomposer validate— no errors🤖 Generated with Claude Code