Skip to content

Commit ab4700f

Browse files
authored
Give the v4 workflow its own file name (#2990)
Renaming the workflow in #2989 was not enough. A workflow is identified by its file path, and the name comes from the copy on the default branch, so this file was still labelled "CI" because main has a ci.yml. test-report.yml on main runs after every workflow named "CI", and it failed on every v4 run, Pester 4 writes NUnit 2.5 XML that dorny/test-reporter cannot read. ci.yml becomes ci-v4.yml, which makes it a separate workflow with its own name. The gate job is still "Done". 🤖
1 parent 8d1848f commit ab4700f

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,14 @@
55
# releasable: green CI here means a security fix can be validated and shipped
66
# through the manual release process (release.ps1).
77
#
8-
# The name differs from the workflow on main and on rel/5.x.x on purpose.
8+
# The file name and the workflow name differ from main and rel/5.x.x on purpose.
99
# test-report.yml on main runs after every workflow named "CI" and renders its
1010
# results, and Pester 4 can only write NUnit 2.5 XML, which dorny/test-reporter
11-
# cannot read. The gate job below is still called "Done", same as everywhere
12-
# else, that is the name branch protection requires.
11+
# cannot read. A workflow is identified by its file path, and its name comes
12+
# from the copy on the default branch, so while this file was also called
13+
# ci.yml the rename alone did nothing and the report kept running and failing.
14+
# The gate job below is still called "Done", same as everywhere else, that is
15+
# the name branch protection requires.
1316
name: CI (v4)
1417

1518
on:

0 commit comments

Comments
 (0)