Repository navigation
fix: BundleAdjust fixed landmarks and pgraph 1.0 Vertex - #129
Merged
Merged
Conversation
add_landmark(fixed=True) raised NameError (appended undefined 'c' rather than the landmark) so a fixed landmark could never be created. ViewPoint and Landmark subclassed pgraph.UVertex, deprecated in pgraph 1.0, giving a DeprecationWarning at import. Subclass pgraph.Vertex when it exists and fall back to UVertex for pgraph 0.6.x. Adds regression tests for both. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codacy flags subprocess.run as a critical security finding. Assert the base class directly instead; pgraph 0.6 has no Vertex so the test skips there. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
add_landmark(P, fixed=True)raisedNameError: name 'c' is not defined(appended an undefinedcinstead of the landmark), so a fixed landmark could never be created.ViewPoint/Landmarksubclassedpgraph.UVertex, deprecated in pgraph 1.0 (DeprecationWarningat import). They now subclasspgraph.Vertexwhen present and fall back toUVertexfor pgraph 0.6.x.Testing
tests/test_bundleadjust.pyand the full suite (947 passed, 96 skipped) against pgraph 0.6.4 (installed) and pgraph 1.0.0 (chore/release-1.0.0worktree viaPYTHONPATH). The two new tests fail onmain.Follow-ups, separate PRs: test coverage (stacked on this one) and a CI pgraph matrix.
🤖 Generated with Claude Code