Repository navigation
ci: test against pgraph 0.6 and latest, require pgraph-python>=0.6.4 - #131
Merged
Merged
Conversation
pgraph 1.0 changed API and BundleAdjust is its only user here, but CI installed whatever pip resolved. Add a pgraph-compat job running the pgraph tests against pgraph-python<1 and the newest release, and make it part of the 'All tests passed' gate. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pgraph-compatCI job runs the pgraph-touching tests on ubuntu / Python 3.12 againstpgraph-python<1and the newest release, and is part of theAll tests passedgate. Until 1.0 is published to PyPI both legs resolve to 0.6.x; the second leg picks up 1.0 automatically when it is released.pyproject.toml:pgraph-python->pgraph-python>=0.6.4(the oldest version tested).Why
pgraph 1.0 has breaking changes (keyword-only graph constructors,
UVertex->Vertex,edges()a list) and BundleAdjust is its only user here, but CI just installed whatever pip resolved.🤖 Generated with Claude Code