Repository navigation
fix: consume Matplotlib format markers - #144
Merged
petercorke merged 3 commits intoOct 17, 2026
Merged
Conversation
Check marker formats, tuple input, option precedence and rejection of unmatched characters.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Owner
|
Thanks — good catch on the marker never being consumed from the format string. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compact-format parser recognizes a marker but leaves it in working_fmt, so valid strings such as 'o', 'ro--', 'g^:' and '-.b*' raise ValueError as unrecognized components.
Remove the matched marker once, like the color and linestyle, before checking for leftover characters. Invalid duplicate markers and unmatched characters still raise.
Added nine checks covering the documented combined formats, a marker alone, tuple input, keyword precedence, and invalid leftovers. Six fail on the original implementation. The valid-format tests also create a Matplotlib line and check its marker.
Validation on Python 3.11:
Full suite on OpenCV 4 and a desktop GUI were not run. This is a one-line production fix, not an extension of the accepted format syntax.