Repository navigation
fix(robot): the first line of print(robot) names the class and the model - #862
Merged
Merged
Conversation
…del, as DHRobot.Puma560 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
enabled auto-merge (squash)
October 19, 2026 21:25
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 7 high |
🟢 Metrics 11 complexity · 0 duplication
Metric Results Complexity 11 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 16846 16851 +5
=====================================
- Misses 16846 16851 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print(robot)began with a hard-codedERobot:for every robot that is not aDHRobot, which is the name of a class that no longer exists, and so said the wrong thing for aRobot, aRobot2and a URDF model.Behaviour change
The first line of the display of a robot is now
X: nameorX.Y: name, whereXis the kind of robot (Robot,Robot2,DHRobotorURDFRobot) andYis the class of the model when it is a subclass, for example:A subclass written by a user shows as
Robot.Mine: .... Code that parses the first line of the display would be affected; the rest of the display is unchanged.Changes
BaseRobot._class_label()gives the label, and is used byBaseRobot.__str__andDHRobot.__str__, which each had a copy of the header. The README example is updated.tests/test_robot_label.py(5 tests): an ETS model, a URDF model, a DH model, the classes themselves (Robot,DHRobot,Robot2), and a user's subclass.Full suite: only the 20
test_servo_half_turnfailures from the stale compiled extension in my worktree; mypy clean. Written with AI assistance (Claude Code).🤖 Generated with Claude Code