fix: integrate the bounded Console sharing proxy and credit its reporter - #209
Merged
Merged
Conversation
Signed-off-by: Feng Ruohang <rh@vonng.com>
Signed-off-by: Feng Ruohang <rh@vonng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server's embedded Console still selected a revision that allowed the anonymous sharing endpoint to reach non-object paths such as internal public metrics. Select the immutable Console revision from Console #56, which confines requests to object-content GETs at the configured S3 origin and rejects redirects. Normal public, presigned and versioned sharing remains available; no new environment variable is introduced.
Credit Jiri Pejchal (@jiri-pejchal), who reported the issue in Console #52, in the contributor record and both README contributor lists. His website profile and avatar have already been published. Record the security change and selected version in the unreleased changelog.
Validation:
make verifiers(Go lint, generated files, module tidiness, credits and compatibility guards), a cleanCGO_ENABLED=0 go build -mod=readonly, and real API/Chromium sharing tests in both embedded and standalone deployments all passed. The binary metadata confirms the selected Console pseudo-version and an unmodified Server commit. Console #56 passed its required CI matrix and vulnerability checks before merging into Console main.This updates source on main. It does not replace already published Server binaries, packages or images, or publish a new Console release.