T16617 model source - #16969
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
source,it cannot be assigned byassign#16617In raising this pull request, I confirm the following:
Fixed
Phalcon\Mvc\Model::assign()andPhalcon\Mvc\Model::writeAttribute()silently dropping values for columns whose name maps to a reserved internal setter (source,schema,dirtyState,connectionService,readConnectionService,writeConnectionService,eventsManager,transaction,snapshotData,oldSnapshotData);Phalcon\Mvc\Model::possibleSetter()returnedtruefor these reserved names while skipping both the setter call and the property assignment, so the value never landed on the model. It now returnsfalsefor reserved setters, letting the caller fall through to direct property assignment while still preventing the reserved internal setter from being hijacked by the columnThanks