Skip to content

T16617 model source - #16969

Merged
niden merged 3 commits into
5.0.xfrom
T16617-model-source
May 2, 2026
Merged

T16617 model source#16969
niden merged 3 commits into
5.0.xfrom
T16617-model-source

Conversation

@niden

@niden niden commented May 2, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Model::assign() and Phalcon\Mvc\Model::writeAttribute() silently dropping values for columns whose name maps to a reserved internal setter (source, schema, dirtyState, connectionService, readConnectionService, writeConnectionService, eventsManager, transaction, snapshotData, oldSnapshotData); Phalcon\Mvc\Model::possibleSetter() returned true for these reserved names while skipping both the setter call and the property assignment, so the value never landed on the model. It now returns false for reserved setters, letting the caller fall through to direct property assignment while still preventing the reserved internal setter from being hijacked by the column

Thanks

@niden
niden requested a review from Jeckerson May 2, 2026 20:13
@niden niden self-assigned this May 2, 2026
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels May 2, 2026
@niden
niden merged commit 29d4826 into 5.0.x May 2, 2026
150 checks passed
@niden
niden deleted the T16617-model-source branch May 2, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant