Skip to content

Commit d760a04

Browse files
committed
fix(ui): ship the nav branding slot empty
It held the literal "phcode.dev", which was never a state the app meant to show - just whatever the markup happened to contain until profile-menu.js repainted it. Every user saw it for the first second of every start, including the ones paying for a plan it was not naming. Nothing belongs here until entitlements resolve, because the slot says either "you could buy Pro" or "you have Pro" and neither is true yet. The comment says so, so that it does not get helpfully filled back in.
1 parent ff0b072 commit d760a04

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎src/index.html‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -922,10 +922,12 @@
922922
<div id="newProject" class="new-project-btn btn-alt-quiet"></div>
923923
</div>
924924
<div>
925-
<!-- placeholder only: profile-menu.js _updateBranding repaints this once entitlements
926-
resolve - localized "Get Phoenix Pro" for free users, plan name for pro users -->
925+
<!-- Deliberately empty: profile-menu.js fills this once it knows what belongs
926+
here - the plan name for pro users, localized "Get Phoenix Pro" for free
927+
ones. Anything shipped here would be a guess made before entitlements
928+
resolve, and it would be shown to every user including the paying ones. -->
927929
<a id="phcode-io-main-nav" href="https://phcode.dev/pricing?promo=FreeNavbar"
928-
target="_blank" rel="noopener">phcode.dev</a>
930+
target="_blank" rel="noopener"></a>
929931
</div>
930932
<div id="mainNavBarRight">
931933
<div id="navBackButton" class="nav-back-btn btn-alt-quiet"><i class="fa-solid fa-arrow-left"></i></div>

0 commit comments

Comments
 (0)