Skip to content

Commit 776a5dc

Browse files
committed
add tests
1 parent 3e76da0 commit 776a5dc

11 files changed

Lines changed: 413 additions & 24 deletions

‎pkg/enqueue-bundle/DependencyInjection/Compiler/ExtractProcessorTagSubscriptionsTrait.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ protected function extractSubscriptions(ContainerBuilder $container, $processorS
5050
$params = $processorClass::getSubscribedCommand();
5151
if (is_string($params)) {
5252
if (empty($params)) {
53-
throw new \LogicException('The command name must not be empty');
53+
throw new \LogicException('The processor name (it is also the command name) must not be empty.');
5454
}
5555

5656
$data[] = [
@@ -61,8 +61,7 @@ protected function extractSubscriptions(ContainerBuilder $container, $processorS
6161
];
6262
} elseif (is_array($params)) {
6363
$params = array_replace($subscriptionPrototype, $params);
64-
65-
if ($processorName = $resolve($params['processorName'])) {
64+
if (false == $processorName = $resolve($params['processorName'])) {
6665
throw new \LogicException('The processor name (it is also the command name) must not be empty.');
6766
}
6867

‎pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildClientRoutingPassTest.php‎

Lines changed: 55 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,12 @@
44

55
use Enqueue\Bundle\DependencyInjection\Compiler\BuildClientRoutingPass;
66
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\InvalidTopicSubscriber;
7+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\OnlyCommandNameSubscriber;
78
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\OnlyTopicNameTopicSubscriber;
9+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\ProcessorNameCommandSubscriber;
810
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\ProcessorNameTopicSubscriber;
911
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\QueueNameTopicSubscriber;
12+
use Enqueue\Client\Config;
1013
use PHPUnit\Framework\TestCase;
1114
use Symfony\Component\DependencyInjection\ContainerBuilder;
1215
use Symfony\Component\DependencyInjection\Definition;
@@ -213,8 +216,6 @@ public function testShouldBuildRouteFromSubscriberIfQueueNameSpecified()
213216

214217
public function testShouldThrowExceptionWhenTopicSubscriberConfigurationIsInvalid()
215218
{
216-
$this->setExpectedException(\LogicException::class, 'Topic subscriber configuration is invalid. "[12345]"');
217-
218219
$container = $this->createContainerBuilder();
219220

220221
$processor = new Definition(InvalidTopicSubscriber::class);
@@ -225,8 +226,60 @@ public function testShouldThrowExceptionWhenTopicSubscriberConfigurationIsInvali
225226
$router->setArguments(['', '']);
226227
$container->setDefinition('enqueue.client.router_processor', $router);
227228

229+
$pass = new BuildClientRoutingPass();
230+
231+
$this->expectException(\LogicException::class);
232+
$this->expectExceptionMessage('Topic subscriber configuration is invalid. "[12345]"');
233+
234+
$pass->process($container);
235+
}
236+
237+
public function testShouldBuildRouteFromCommandSubscriberIfOnlyCommandNameSpecified()
238+
{
239+
$container = $this->createContainerBuilder();
240+
241+
$processor = new Definition(OnlyCommandNameSubscriber::class);
242+
$processor->addTag('enqueue.client.processor');
243+
$container->setDefinition('processor-service-id', $processor);
244+
245+
$router = new Definition();
246+
$router->setArguments([null, null, null]);
247+
$container->setDefinition('enqueue.client.router_processor', $router);
248+
249+
$pass = new BuildClientRoutingPass();
250+
$pass->process($container);
251+
252+
$expectedRoutes = [
253+
Config::COMMAND_TOPIC => [
254+
['the-command-name', 'aDefaultQueueName'],
255+
],
256+
];
257+
258+
$this->assertEquals($expectedRoutes, $router->getArgument(1));
259+
}
260+
261+
public function testShouldBuildRouteFromCommandSubscriberIfProcessorNameSpecified()
262+
{
263+
$container = $this->createContainerBuilder();
264+
265+
$processor = new Definition(ProcessorNameCommandSubscriber::class);
266+
$processor->addTag('enqueue.client.processor');
267+
$container->setDefinition('processor-service-id', $processor);
268+
269+
$router = new Definition();
270+
$router->setArguments([null, null, null]);
271+
$container->setDefinition('enqueue.client.router_processor', $router);
272+
228273
$pass = new BuildClientRoutingPass();
229274
$pass->process($container);
275+
276+
$expectedRoutes = [
277+
Config::COMMAND_TOPIC => [
278+
['the-command-name', 'the-command-queue-name'],
279+
],
280+
];
281+
282+
$this->assertEquals($expectedRoutes, $router->getArgument(1));
230283
}
231284

232285
/**

‎pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildProcessorRegistryPassTest.php‎

Lines changed: 90 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,12 @@
33
namespace Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler;
44

55
use Enqueue\Bundle\DependencyInjection\Compiler\BuildProcessorRegistryPass;
6+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\EmptyCommandSubscriber;
7+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\InvalidCommandSubscriber;
68
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\InvalidTopicSubscriber;
9+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\OnlyCommandNameSubscriber;
710
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\OnlyTopicNameTopicSubscriber;
11+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\ProcessorNameCommandSubscriber;
812
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\ProcessorNameTopicSubscriber;
913
use PHPUnit\Framework\TestCase;
1014
use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -152,7 +156,8 @@ public function testShouldBuildRouteFromSubscriberIfProcessorNameSpecified()
152156

153157
public function testShouldThrowExceptionWhenTopicSubscriberConfigurationIsInvalid()
154158
{
155-
$this->setExpectedException(\LogicException::class, 'Topic subscriber configuration is invalid. "[12345]"');
159+
$this->expectException(\LogicException::class);
160+
$this->expectExceptionMessage('Topic subscriber configuration is invalid. "[12345]"');
156161

157162
$container = $this->createContainerBuilder();
158163

@@ -168,6 +173,90 @@ public function testShouldThrowExceptionWhenTopicSubscriberConfigurationIsInvali
168173
$pass->process($container);
169174
}
170175

176+
public function testShouldBuildRouteFromOnlyNameCommandSubscriber()
177+
{
178+
$container = $this->createContainerBuilder();
179+
180+
$processor = new Definition(OnlyCommandNameSubscriber::class);
181+
$processor->addTag('enqueue.client.processor');
182+
$container->setDefinition('processor-id', $processor);
183+
184+
$processorRegistry = new Definition();
185+
$processorRegistry->setArguments([]);
186+
$container->setDefinition('enqueue.client.processor_registry', $processorRegistry);
187+
188+
$pass = new BuildProcessorRegistryPass();
189+
$pass->process($container);
190+
191+
$expectedValue = [
192+
'the-command-name' => 'processor-id',
193+
];
194+
195+
$this->assertEquals($expectedValue, $processorRegistry->getArgument(0));
196+
}
197+
198+
public function testShouldBuildRouteFromProcessorNameCommandSubscriber()
199+
{
200+
$container = $this->createContainerBuilder();
201+
202+
$processor = new Definition(ProcessorNameCommandSubscriber::class);
203+
$processor->addTag('enqueue.client.processor');
204+
$container->setDefinition('processor-id', $processor);
205+
206+
$processorRegistry = new Definition();
207+
$processorRegistry->setArguments([]);
208+
$container->setDefinition('enqueue.client.processor_registry', $processorRegistry);
209+
210+
$pass = new BuildProcessorRegistryPass();
211+
$pass->process($container);
212+
213+
$expectedValue = [
214+
'the-command-name' => 'processor-id',
215+
];
216+
217+
$this->assertEquals($expectedValue, $processorRegistry->getArgument(0));
218+
}
219+
220+
public function testShouldThrowExceptionWhenProcessorNameEmpty()
221+
{
222+
$container = $this->createContainerBuilder();
223+
224+
$processor = new Definition(EmptyCommandSubscriber::class);
225+
$processor->addTag('enqueue.client.processor');
226+
$container->setDefinition('processor-id', $processor);
227+
228+
$processorRegistry = new Definition();
229+
$processorRegistry->setArguments([]);
230+
$container->setDefinition('enqueue.client.processor_registry', $processorRegistry);
231+
232+
$pass = new BuildProcessorRegistryPass();
233+
234+
$this->expectException(\LogicException::class);
235+
$this->expectExceptionMessage('The processor name (it is also the command name) must not be empty.');
236+
237+
$pass->process($container);
238+
}
239+
240+
public function testShouldThrowExceptionWhenCommandSubscriberConfigurationIsInvalid()
241+
{
242+
$container = $this->createContainerBuilder();
243+
244+
$processor = new Definition(InvalidCommandSubscriber::class);
245+
$processor->addTag('enqueue.client.processor');
246+
$container->setDefinition('processor-id', $processor);
247+
248+
$processorRegistry = new Definition();
249+
$processorRegistry->setArguments([]);
250+
$container->setDefinition('enqueue.client.processor_registry', $processorRegistry);
251+
252+
$pass = new BuildProcessorRegistryPass();
253+
254+
$this->expectException(\LogicException::class);
255+
$this->expectExceptionMessage('Command subscriber configuration is invalid. "12345"');
256+
257+
$pass->process($container);
258+
}
259+
171260
/**
172261
* @return ContainerBuilder
173262
*/

‎pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildQueueMetaRegistryPassTest.php‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
namespace Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler;
44

55
use Enqueue\Bundle\DependencyInjection\Compiler\BuildQueueMetaRegistryPass;
6+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\OnlyCommandNameSubscriber;
67
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\OnlyTopicNameTopicSubscriber;
8+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\ProcessorNameCommandSubscriber;
79
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\ProcessorNameTopicSubscriber;
810
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\QueueNameTopicSubscriber;
911
use PHPUnit\Framework\TestCase;
@@ -192,6 +194,50 @@ public function testShouldBuildQueueFromSubscriberIfQueueNameSpecified()
192194
$this->assertEquals($expectedQueues, $registry->getArgument(1));
193195
}
194196

197+
public function testShouldBuildQueueFromCommandSubscriber()
198+
{
199+
$container = $this->createContainerBuilder();
200+
201+
$processor = new Definition(ProcessorNameCommandSubscriber::class);
202+
$processor->addTag('enqueue.client.processor');
203+
$container->setDefinition('processor-service-id', $processor);
204+
205+
$registry = new Definition();
206+
$registry->setArguments([null, []]);
207+
$container->setDefinition('enqueue.client.meta.queue_meta_registry', $registry);
208+
209+
$pass = new BuildQueueMetaRegistryPass();
210+
$pass->process($container);
211+
212+
$expectedQueues = [
213+
'the-command-queue-name' => ['processors' => ['the-command-name']],
214+
];
215+
216+
$this->assertEquals($expectedQueues, $registry->getArgument(1));
217+
}
218+
219+
public function testShouldBuildQueueFromOnlyCommandNameSubscriber()
220+
{
221+
$container = $this->createContainerBuilder();
222+
223+
$processor = new Definition(OnlyCommandNameSubscriber::class);
224+
$processor->addTag('enqueue.client.processor');
225+
$container->setDefinition('processor-service-id', $processor);
226+
227+
$registry = new Definition();
228+
$registry->setArguments([null, []]);
229+
$container->setDefinition('enqueue.client.meta.queue_meta_registry', $registry);
230+
231+
$pass = new BuildQueueMetaRegistryPass();
232+
$pass->process($container);
233+
234+
$expectedQueues = [
235+
'aDefaultQueueName' => ['processors' => ['the-command-name']],
236+
];
237+
238+
$this->assertEquals($expectedQueues, $registry->getArgument(1));
239+
}
240+
195241
/**
196242
* @return ContainerBuilder
197243
*/

‎pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildTopicMetaSubscribersPassTest.php‎

Lines changed: 51 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@
44

55
use Enqueue\Bundle\DependencyInjection\Compiler\BuildTopicMetaSubscribersPass;
66
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\InvalidTopicSubscriber;
7+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\OnlyCommandNameSubscriber;
78
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\OnlyTopicNameTopicSubscriber;
9+
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\ProcessorNameCommandSubscriber;
810
use Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock\ProcessorNameTopicSubscriber;
11+
use Enqueue\Client\Config;
912
use PHPUnit\Framework\TestCase;
1013
use Symfony\Component\DependencyInjection\ContainerBuilder;
1114
use Symfony\Component\DependencyInjection\Definition;
@@ -285,8 +288,6 @@ public function testShouldBuildMetaFromSubscriberIfProcessorNameSpecified()
285288

286289
public function testShouldThrowExceptionWhenTopicSubscriberConfigurationIsInvalid()
287290
{
288-
$this->setExpectedException(\LogicException::class, 'Topic subscriber configuration is invalid. "[12345]"');
289-
290291
$container = $this->createContainerBuilder();
291292

292293
$processor = new Definition(InvalidTopicSubscriber::class);
@@ -297,8 +298,56 @@ public function testShouldThrowExceptionWhenTopicSubscriberConfigurationIsInvali
297298
$topicMetaRegistry->setArguments([[]]);
298299
$container->setDefinition('enqueue.client.meta.topic_meta_registry', $topicMetaRegistry);
299300

301+
$pass = new BuildTopicMetaSubscribersPass();
302+
303+
$this->expectException(\LogicException::class);
304+
$this->expectExceptionMessage('Topic subscriber configuration is invalid. "[12345]"');
305+
306+
$pass->process($container);
307+
}
308+
309+
public function testShouldBuildMetaFromCommandSubscriberIfOnlyCommandNameSpecified()
310+
{
311+
$container = $this->createContainerBuilder();
312+
313+
$processor = new Definition(OnlyCommandNameSubscriber::class);
314+
$processor->addTag('enqueue.client.processor');
315+
$container->setDefinition('processor-id', $processor);
316+
317+
$topicMetaRegistry = new Definition();
318+
$topicMetaRegistry->setArguments([[]]);
319+
$container->setDefinition('enqueue.client.meta.topic_meta_registry', $topicMetaRegistry);
320+
321+
$pass = new BuildTopicMetaSubscribersPass();
322+
$pass->process($container);
323+
324+
$expectedValue = [
325+
Config::COMMAND_TOPIC => ['processors' => ['the-command-name']],
326+
];
327+
328+
$this->assertEquals($expectedValue, $topicMetaRegistry->getArgument(0));
329+
}
330+
331+
public function testShouldBuildMetaFromCommandSubscriberIfProcessorNameSpecified()
332+
{
333+
$container = $this->createContainerBuilder();
334+
335+
$processor = new Definition(ProcessorNameCommandSubscriber::class);
336+
$processor->addTag('enqueue.client.processor');
337+
$container->setDefinition('processor-id', $processor);
338+
339+
$topicMetaRegistry = new Definition();
340+
$topicMetaRegistry->setArguments([[]]);
341+
$container->setDefinition('enqueue.client.meta.topic_meta_registry', $topicMetaRegistry);
342+
300343
$pass = new BuildTopicMetaSubscribersPass();
301344
$pass->process($container);
345+
346+
$expectedValue = [
347+
Config::COMMAND_TOPIC => ['processors' => ['the-command-name']],
348+
];
349+
350+
$this->assertEquals($expectedValue, $topicMetaRegistry->getArgument(0));
302351
}
303352

304353
/**
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?php
2+
3+
namespace Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock;
4+
5+
use Enqueue\Client\CommandSubscriberInterface;
6+
7+
class EmptyCommandSubscriber implements CommandSubscriberInterface
8+
{
9+
public static function getSubscribedCommand()
10+
{
11+
return '';
12+
}
13+
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?php
2+
3+
namespace Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock;
4+
5+
use Enqueue\Client\CommandSubscriberInterface;
6+
7+
class InvalidCommandSubscriber implements CommandSubscriberInterface
8+
{
9+
public static function getSubscribedCommand()
10+
{
11+
return 12345;
12+
}
13+
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?php
2+
3+
namespace Enqueue\Bundle\Tests\Unit\DependencyInjection\Compiler\Mock;
4+
5+
use Enqueue\Client\CommandSubscriberInterface;
6+
7+
class OnlyCommandNameSubscriber implements CommandSubscriberInterface
8+
{
9+
public static function getSubscribedCommand()
10+
{
11+
return 'the-command-name';
12+
}
13+
}

0 commit comments

Comments
 (0)