Skip to content

Commit cb43aec

Browse files
committed
enqueue client extension interface segregation
1 parent 170bf32 commit cb43aec

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎pkg/enqueue/Tests/Client/Extension/PrepareBodyExtensionTest.php‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@
44

55
use Enqueue\Client\DriverInterface;
66
use Enqueue\Client\Extension\PrepareBodyExtension;
7-
use Enqueue\Client\ExtensionInterface;
87
use Enqueue\Client\Message;
98
use Enqueue\Client\PreSend;
9+
use Enqueue\Client\PreSendCommandExtensionInterface;
10+
use Enqueue\Client\PreSendEventExtensionInterface;
1011
use Enqueue\Client\ProducerInterface;
1112
use Enqueue\Tests\Mocks\JsonSerializableObject;
1213
use PHPUnit\Framework\TestCase;
@@ -17,7 +18,8 @@ public function testShouldImplementExtensionInterface()
1718
{
1819
$rc = new \ReflectionClass(PrepareBodyExtension::class);
1920

20-
$this->assertTrue($rc->implementsInterface(ExtensionInterface::class));
21+
$this->assertTrue($rc->implementsInterface(PreSendEventExtensionInterface::class));
22+
$this->assertTrue($rc->implementsInterface(PreSendCommandExtensionInterface::class));
2123
}
2224

2325
public function testCouldConstructedWithoutAnyArguments()

‎pkg/enqueue/Tests/Client/ProducerSendCommandTest.php‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Enqueue\Tests\Client;
44

5+
use Enqueue\Client\ChainExtension;
56
use Enqueue\Client\Config;
67
use Enqueue\Client\DriverInterface;
78
use Enqueue\Client\DriverPreSend;
@@ -304,7 +305,7 @@ public function testShouldSerializeMessageByCustomExtension()
304305
})
305306
;
306307

307-
$producer = new Producer($driver, $this->createRpcFactoryMock(), new CustomPrepareBodyClientExtension());
308+
$producer = new Producer($driver, $this->createRpcFactoryMock(), new ChainExtension([new CustomPrepareBodyClientExtension()]));
308309
$producer->sendCommand('command', ['foo' => 'fooVal']);
309310
}
310311

‎pkg/enqueue/Tests/Client/ProducerSendEventTest.php‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Enqueue\Tests\Client;
44

5+
use Enqueue\Client\ChainExtension;
56
use Enqueue\Client\Config;
67
use Enqueue\Client\DriverInterface;
78
use Enqueue\Client\DriverPreSend;
@@ -210,7 +211,7 @@ public function testShouldSerializeMessageByCustomExtension()
210211
})
211212
;
212213

213-
$producer = new Producer($driver, $this->createRpcFactoryMock(), new CustomPrepareBodyClientExtension());
214+
$producer = new Producer($driver, $this->createRpcFactoryMock(), new ChainExtension([new CustomPrepareBodyClientExtension()]));
214215
$producer->sendEvent('topic', ['foo' => 'fooVal']);
215216
}
216217

0 commit comments

Comments
 (0)