Skip to content

Commit f0292ca

Browse files
committed
[consumption] add ability to change reply status
1 parent d9035ce commit f0292ca

2 files changed

Lines changed: 31 additions & 4 deletions

File tree

‎pkg/enqueue/Consumption/Result.php‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,16 @@ public static function requeue($reason = '')
119119

120120
/**
121121
* @param PsrMessage $replyMessage
122+
* @param string $status
122123
* @param string|null $reason
123124
*
124125
* @return Result
125126
*/
126-
public static function reply(PsrMessage $replyMessage, $reason = '')
127+
public static function reply(PsrMessage $replyMessage, $status = self::ACK, $reason = null)
127128
{
128-
$result = static::ack($reason);
129+
$status = null === $status ? self::ACK : $status;
130+
131+
$result = new static($status, $reason);
129132
$result->setReply($replyMessage);
130133

131134
return $result;

‎pkg/enqueue/Tests/Consumption/ResultTest.php‎

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,35 @@ public function testCouldConstructedWithRequeueFactoryMethod()
5353
$this->assertSame(null, $result->getReply());
5454
}
5555

56-
public function testCouldConstructedWithReplyFactoryMethod()
56+
public function testCouldConstructedWithReplyFactoryMethodAndAckStatusByDefault()
5757
{
5858
$reply = new NullMessage();
5959

60-
$result = Result::reply($reply, 'theReason');
60+
$result = Result::reply($reply);
61+
62+
$this->assertInstanceOf(Result::class, $result);
63+
$this->assertSame(Result::ACK, $result->getStatus());
64+
$this->assertSame('', $result->getReason());
65+
$this->assertSame($reply, $result->getReply());
66+
}
67+
68+
public function testCouldConstructedWithReplyFactoryMethodAndRejectStatusExplicitly()
69+
{
70+
$reply = new NullMessage();
71+
72+
$result = Result::reply($reply, Result::REJECT);
73+
74+
$this->assertInstanceOf(Result::class, $result);
75+
$this->assertSame(Result::REJECT, $result->getStatus());
76+
$this->assertSame('', $result->getReason());
77+
$this->assertSame($reply, $result->getReply());
78+
}
79+
80+
public function testCouldConstructedWithReplyFactoryMethodAndReasonSet()
81+
{
82+
$reply = new NullMessage();
83+
84+
$result = Result::reply($reply, null, 'theReason');
6185

6286
$this->assertInstanceOf(Result::class, $result);
6387
$this->assertSame(Result::ACK, $result->getStatus());

0 commit comments

Comments
 (0)