Added CVEs to crypt - #3447
Merged
Merged
Conversation
Member
|
I have no idea why mentioning those CVEs in the way you did improves the documentations. The point of the The security issues with the function are well known and if that is the issue with this page it would make more sense to add a warning block somewhere in this page to warn about this. |
Contributor
Author
|
I was trying for minimal changes but you're right. I turned it into a warning. |
cmb69
reviewed
Jul 21, 2024
cmb69
left a comment
cmb69
left a comment
Member
There was a problem hiding this comment.
This looks like a reasonable addition to the docs now (barring my suggestion maybe).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also there should maybe be a note on
CRYPT_STD_DESto state it's worse thanCRYPT_MD5andCRYPT_MD5was EOLed because it was not good enough.CRYPT_STD_DEShas a fixed 25 iterations of DES.CRYPT_MD5has a fixed 1000 iterations of MD5.CRYPT_STD_DESis 102x faster to crack thanCRYPT_MD5on a RTX 4090.