property_exists: Update example to show more scenarios. - #4508
Merged
Conversation
Girgias
reviewed
Mar 6, 2025
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
I think it would be better to split this into a new example, and have that one have a description to explain the intent
The main thing to highlight is that property visibility and `__get` and `__isset` is not checked.
… visibility/magic methods example
lacatoire
force-pushed
the
patch-property-exists
branch
from
September 2, 2026 09:01
2f27992 to
331b1b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main thing to highlight is that property visibility and
__getand__issetis not checked.This example may be a little too complex and hides the intent. Would it be better to explicitly state the lack of visibility check in the description instead?