Simplifiying the "A simple tutorial" page - #4953
Merged
Merged
Conversation
… and MySQL pre-requisites and using php's builtin server
TimWolla
requested changes
Oct 24, 2025
TimWolla
left a comment
Member
There was a problem hiding this comment.
Thank you. I have some comments, but this definitely looks like an improvement to me.
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
TimWolla
approved these changes
Oct 28, 2025
TimWolla
left a comment
Member
There was a problem hiding this comment.
LGTM. Given the prominent spot of this page, I'd like to see another approval before merging.
Girgias
reviewed
Oct 31, 2025
Comment on lines
30
to
50
| @@ -74,16 +37,24 @@ | |||
| echo "Hello World!"; | |||
|
|
|||
| ?> | |||
| ]]> | |||
| </programlisting> | |||
| <simpara> | |||
| Using your terminal, navigate to the directory containing this file and | |||
| start a development server with the following command: | |||
| </simpara> | |||
| <programlisting role="shell"> | |||
| <![CDATA[ | |||
| php -S localhost:8000 | |||
| ]]> | |||
| </programlisting> | |||
Member
There was a problem hiding this comment.
Does the "example" tag+title even provide any benefit?
Maybe just moving all of it into the normal flow is better? But I don't have strong opinions about this and the new text is an improvement over the current one.
kamil-tekiela
approved these changes
Oct 31, 2025
Crell
pushed a commit
to Crell/doc-en
that referenced
this pull request
Dec 15, 2025
* doc: Simplifiying the "A simple tutorial" page by removing the Apache and MySQL pre-requisites and using php's builtin server * Apply suggestions from code review Co-authored-by: Tim Düsterhus <timwolla@googlemail.com> * Update chapters/tutorial.xml Co-authored-by: Tim Düsterhus <timwolla@googlemail.com> * Adding closing tag to examples * Removing trailing whitespace --------- Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifiying the "A simple tutorial" page by removing the Apache and MySQL pre-requisites and using php's builtin server