Fix GH-1132: Document mb_strlen invalid encoding behavior change in P… - #5418
Conversation
|
Hi, i checked in php-src and the Currently only |
|
@lacatoire is right. This change was done to multiple functions and such such should be documented consistently. php/php-src@90eeca2#diff-28e30bf65ac518b331e0315af123e060f35e9053d7c05b68b5bcbcd1be080ba4 Since the change was already documented in one place, all you need to do is take it out and put it into a new snippet (language-snippets.ent) and then use that snippet for all the changed functions. Both the |
…nippets - Add mbstring.errors.encoding-invalid and mbstring.changelog.encoding-invalid entities to language-snippets.ent for consistent documentation - Use these entities in mb_strlen, mb_internal_encoding, and mb_encoding_aliases, replacing per-function custom prose and fixing classname -> exceptionname - Document that passing an invalid encoding to mb_strlen now throws a ValueError as of PHP 8.0.0; previously an E_WARNING was emitted and false was returned Fixes phpGH-1132
da882ef to
3713d65
Compare
Fixes #1132
Documents that passing an invalid encoding to
mb_strlen()had undefined behavior before PHP 8.0 (could returnfalse) and that as of PHP 8.0 aValueErroris thrown instead, as suggested in the issue discussion.