Repository navigation
Commit 2c623e8
authored
fix: validate embedded app paths with filepath.IsLocal (#2721)
Replaces the `nativeRelPath` helper copied from `x/build` with
`filepath.IsLocal`, which rejects absolute paths, `..` traversal, volume
names and, on Windows, reserved names. The behavior is the same for
valid archives and the code is shorter.
CodeQL recognizes `filepath.IsLocal` as a path sanitizer, which resolves
https://github.com/php/frankenphp/security/code-scanning/1. The archive
is embedded at build time, so this alert was not exploitable in
practice.
Found while setting up CodeQL in
#2720.1 parent c6fac3b commit 2c623e8
1 file changed
Lines changed: 3 additions & 45 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | | - | |
17 | 15 | | |
18 | 16 | | |
19 | 17 | | |
| |||
75 | 73 | | |
76 | 74 | | |
77 | 75 | | |
78 | | - | |
79 | | - | |
80 | | - | |
| 76 | + | |
| 77 | + | |
81 | 78 | | |
82 | | - | |
| 79 | + | |
83 | 80 | | |
84 | 81 | | |
85 | 82 | | |
| |||
155 | 152 | | |
156 | 153 | | |
157 | 154 | | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
0 commit comments