Repository navigation
Commit 89bf4d5
authored
ci: install libbrotli-dev instead of reinstalling it (#2723)
#2391 added `apt-get install
--reinstall -y libbrotli-dev` because the ubuntu-24.04 image listed
`libbrotli-dev` as installed while its headers and `.pc` files were
missing, which turned a plain install into a no-op.
That state is gone. The latest `main` run (image 20261004.327.1,
https://github.com/php/frankenphp/actions/runs/38149908385) shows `The
following NEW packages will be installed: libbrotli-dev`: the image no
longer ships the package at all, only the `brotli` CLI (see the [image
readme](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md)).
Nothing will be fixed upstream, so the step stays, as a regular install,
and the TODO goes away.1 parent c035bcf commit 89bf4d5
2 files changed
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
171 | | - | |
172 | | - | |
| 171 | + | |
| 172 | + | |
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | | - | |
| 52 | + | |
| 53 | + | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
| |||
0 commit comments