Fix migration

Author: iMattPro

migrations/v30x/m20_unicode_language_trees.php

@@ -39,18 +39,14 @@ public function update_schema()
 	}
 
 	/**
-	 * {@inheritdoc}
+	 * Keep the changed columns until the initial schema migration drops the table.
+	 * Reverting them could fail when existing data no longer fits the old types.
+	 *
+	 * @return array Array of table schema changes
 	 */
 	public function revert_schema()
 	{
-		return array(
-			'change_columns' => array(
-				$this->table_prefix . 'boardrules' => array(
-					'rule_title' => array('VCHAR:200', ''),
-					'rule_anchor' => array('VCHAR:255', ''),
-				),
-			),
-		);
+		return array();
 	}
 
 	/**

tests/migrations/v310_upgrade_test.php

@@ -190,27 +190,4 @@ public function test_table_lock_config_is_removed_only_on_revert(): void
 			array('config.remove', array('boardrules.table_lock.boardrules_table')),
 		), $migration->revert_data());
 	}
-
-	public function test_unicode_schema_is_reversible(): void
-	{
-		global $phpbb_root_path, $phpEx;
-		$factory = new \phpbb\db\tools\factory();
-		$migration = new \phpbb\boardrules\migrations\v30x\m20_unicode_language_trees(
-			new \phpbb\config\config(array()),
-			$this->db,
-			$factory->get($this->db, true),
-			$phpbb_root_path,
-			$phpEx,
-			'phpbb_'
-		);
-
-		self::assertSame(array(
-			'change_columns' => array(
-				'phpbb_boardrules' => array(
-					'rule_title' => array('VCHAR:200', ''),
-					'rule_anchor' => array('VCHAR:255', ''),
-				),
-			),
-		), $migration->revert_schema());
-	}
 }