Repository navigation
PWA Toggle Option - #149
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the ACP-controlled PWA metadata toggle and its related configuration, rendering, localization, and coverage changes.
No open issues 🎉
What changed in this PR
Adds an ACP-controlled option to disable extension-generated PWA metadata while preserving Web Push functionality and the install banner.
Changes:
- Adds and migrates the
pwa_metadata_enabledconfiguration option, enabled by default. - Conditionally renders PWA manifest and related metadata.
- Adds ACP controls, English/Russian translations, and test coverage.
- Updates Composer platform and dependency lock metadata.
| File | Description |
|---|---|
tests/functional/functional_test.php |
Tests enabling and disabling PWA metadata output. |
tests/event/listener_test.php |
Verifies the metadata-enabled template variable. |
tests/controller/controller_acp_test.php |
Covers saving and displaying the ACP setting. |
styles/all/template/event/overall_header_head_append.html |
Conditionally renders PWA metadata; the theme-color CSS variable should remain available when metadata is disabled. |
migrations/add_pwa_metadata_toggle.php |
Adds the persisted configuration option. |
language/ru/webpushnotifications_module_acp.php |
Adds Russian ACP labels and help text. |
language/en/webpushnotifications_module_acp.php |
Adds English ACP labels and help text. |
event/listener.php |
Assigns the metadata-enabled template variable. |
controller/acp_controller.php |
Displays and saves the ACP setting. |
composer.lock |
Updates dependency lock metadata and package versions. |
composer.json |
Defines the PHP platform version for dependency resolution. |
adm/style/wpn_acp_pwa.html |
Adds enable/disable ACP controls. |
This pull request requires changes.
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=========================================
Coverage 98.23% 98.23%
Complexity 276 276
=========================================
Files 11 11
Lines 792 794 +2
=========================================
+ Hits 778 780 +2
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rxu
reviewed
Nov 9, 2026
Co-authored-by: rxu <rxu@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option to disable extension-generated PWA metadata for boards that provide their own PWA setup.