fix: restore missing now timestamp in create_run and auto-release lock on initialization failure

Author: meis2m

core/engine/migration_engine.php

@@ -119,33 +119,41 @@ public function start_run(string $source_system, migration_config_dto $config):
 			throw new \RuntimeException("Another migration is already running for source: {$source_system}");
 		}
 
-		$run_state = $this->state_manager->create_run($run_id, $source_system, $source_version, $config);
+		try
+		{
+			$run_state = $this->state_manager->create_run($run_id, $source_system, $source_version, $config);
 
-		// Resolve ordered steps
-		$requested_steps = !empty($config->selected_steps) ? $config->selected_steps : $provider->get_supported_steps();
-		$ordered_steps = $this->step_registry->resolve_order($requested_steps, $source_system);
+			// Resolve ordered steps
+			$requested_steps = !empty($config->selected_steps) ? $config->selected_steps : $provider->get_supported_steps();
+			$ordered_steps = $this->step_registry->resolve_order($requested_steps, $source_system);
 
-		$steps_init = [];
-		foreach ($ordered_steps as $order => $step_name)
-		{
-			$total = $provider->get_total_records($step_name, $config);
-			$max_id = $provider->get_max_source_id($step_name, $config);
-			$steps_init[] = [
-				'step_name'     => $step_name,
-				'step_order'    => $order + 1,
-				'total_records' => $total,
-				'max_source_id' => $max_id,
-			];
-		}
+			$steps_init = [];
+			foreach ($ordered_steps as $order => $step_name)
+			{
+				$total = $provider->get_total_records($step_name, $config);
+				$max_id = $provider->get_max_source_id($step_name, $config);
+				$steps_init[] = [
+					'step_name'     => $step_name,
+					'step_order'    => $order + 1,
+					'total_records' => $total,
+					'max_source_id' => $max_id,
+				];
+			}
 
-		$this->state_manager->init_steps($run_id, $steps_init);
-		$this->state_manager->update_run_status($run_id, 'ready', $ordered_steps[0] ?? '');
+			$this->state_manager->init_steps($run_id, $steps_init);
+			$this->state_manager->update_run_status($run_id, 'ready', $ordered_steps[0] ?? '');
 
-		// Release initial creation lock so it is not held idly before batches start
-		$this->lock_manager->release($lock_name, $run_id);
+			// Release initial creation lock so it is not held idly before batches start
+			$this->lock_manager->release($lock_name, $run_id);
 
-		$run_state = $this->state_manager->get_run($run_id);
-		return $run_state;
+			$run_state = $this->state_manager->get_run($run_id);
+			return $run_state;
+		}
+		catch (\Throwable $e)
+		{
+			$this->lock_manager->release($lock_name, $run_id);
+			throw $e;
+		}
 	}
 
 	/**

core/state/lock_manager.php

@@ -85,17 +85,23 @@ public function acquire(string $lock_name, string $run_id, string $worker_type =
 
 		// Check if previous run is completed or failed
 		$prev_run_status = '';
+		$run_exists = false;
 		if (!empty($existing_lock['run_id']))
 		{
 			$runs_table = str_replace('migration_locks', 'migration_runs', $this->table_name);
 			$sql = 'SELECT status FROM ' . $runs_table . ' WHERE run_id = ' . "'" . $this->db->sql_escape($existing_lock['run_id']) . "'";
 			$r_res = $this->db->sql_query($sql);
-			$prev_run_status = (string)$this->db->sql_fetchfield('status');
+			$row = $this->db->sql_fetchrow($r_res);
+			if ($row)
+			{
+				$run_exists = true;
+				$prev_run_status = (string)$row['status'];
+			}
 			$this->db->sql_freeresult($r_res);
 		}
 
 		$is_stale = ((int)$existing_lock['heartbeat_at'] < $stale_threshold);
-		$is_finished = in_array($prev_run_status, ['completed', 'finalized', 'rolled_back', 'abandoned', 'failed'], true);
+		$is_finished = (!$run_exists && !empty($existing_lock['run_id'])) || in_array($prev_run_status, ['completed', 'finalized', 'rolled_back', 'abandoned', 'failed'], true);
 
 		// If the lock is held by the EXACT same full worker_id, refresh heartbeat
 		if ($existing_lock['worker_id'] === $full_worker_id && $existing_lock['run_id'] === $run_id)

core/state/state_manager.php

@@ -114,6 +114,7 @@ public function generate_run_id(): string
 	 */
 	public function create_run(string $run_id, string $source_system, string $source_version, migration_config_dto $config): run_state_dto
 	{
+		$now = time();
 		$options = $config->to_array(true); // Must include database credentials so batch workers can connect
 
 		$data = [