Repository navigation
Declare the PHP 8.3.36 minimum in composer.json, README and CI - #52
Merged
Merged
Conversation
ext.php has refused to enable below PHP 8.3.36 since #49, but composer.json and the README still said PHP 7.4, and CI still ran the code sniffer and lint on PHP 7.4 and 8.2. They now match: composer.json requires >=8.3.36, the README says 8.3.36, and both CI workflows use PHP 8.3 (lint also keeps 8.4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #49,
ext.phprefuses to enable Contact Admin below PHP 8.3.36. Other places in the repository still said PHP 7.4, and that mismatch is now in the published 1.6.1-dev ZIP'scomposer.json.Changes
composer.json:"php": ">=8.3.36"(was>=7.4). The phpBB constraint is unchanged.tests.yml: the phpBB 3.3 and phpBB 4.0 code sniffer jobs run on PHP 8.3 instead of 7.4 and 8.2. The check names change to "PHP 8.3 - none" and "PHP 8.3 - none - phpBB 4.0". No check names are required onmaster.lint.yml: lints on PHP 8.3 and 8.4 instead of 7.4 and 8.4, and its header comment is updated.ext.phpand the language string already say 8.3.36 and are unchanged.Testing
composer validatepasses locally. The CI logs will show which PHP 8.3 patch releasesetup-phpinstalls. The workflows ask only for8.3, so this PR does not guarantee the runner has 8.3.36 or later. The jobs don't enable the extension, so the patch level doesn't affect them.After this merges, the 1.6.1-dev ZIP needs one more refresh so its
composer.jsonmatches.Investigated and written by Claude on behalf of William Jacoby (bonelifer).