Repository navigation
Add an optional introduction above the Knowledge Base index - #14
Merged
Merged
Conversation
The ACP configuration page gets a switch, a text box and a Markdown option for a short introduction shown under the Knowledge Base title, on the hierarchical index and the flat index. It is written in BBCode or Markdown and stored through the same article_text service as articles. Migration version_2_0_33 adds it switched off, holding the text kinerity/knowledgebase showed above its index, and switches it on on a board imported from kinerity, so its visitors keep seeing it. Tests: kb_intro_test.php (default text, display switch, saving BBCode and Markdown, emptying, the migration and its kinerity check). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bonelifer
force-pushed
the
feature/kb-intro-text
branch
from
November 12, 2026 10:44
3414417 to
be6af8f
Compare
EPV fails on htmlspecialchars() in inc/kinerity_import.php (merged in #13, so main fails its EPV check) and inc/intro.php. They now call phpBB's utf8_htmlspecialchars(), which does the same (ENT_COMPAT, UTF-8). inc/default_content.php no longer defines IN_PHPBB itself, which EPV also flagged; phpBB always defines it, and the tests do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Pushed 77fd815, which fixes the two EPV failures:
Claude ran EPV locally against phpBB 3.3.x and master: no findings outside Investigated and written by Claude on behalf of William Jacoby (bonelifer). |
bonelifer
added a commit
that referenced
this pull request
Nov 12, 2026
Brings in the index introduction (#14), which also clears the EPV finding in inc/kinerity_import.php. Both new docs/testing.md sections are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional introduction above the Knowledge Base index, like the text kinerity/knowledgebase showed there.
Builds on the kinerity import PR. Merge that one first.
version_2_0_33fills the text box with kinerity's text, in the board's default language (from the newdefault_content.phplanguage file).Tests:
tests/kb_intro_test.phpcovers the default text, the display switch, saving BBCode and Markdown, emptying the text, and the migration. Claude ran the migration on the phpBB 3.3 board imported from kinerity: the intro came up switched on, in the same place as on the kinerity board. In the ACP, Claude saved BBCode and then Markdown text, saw both displayed formatted on the flat and hierarchical index, and saw nothing once the intro was switched off. The full suite passes on phpBB 3.3.x and master.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code