Translate the old-extension message in ext.php (#9)

ext.php refused to enable with a hard-coded English message while the old extension was still enabled. The message now comes from the install language file, as phpBB's validation policy requires.

The migration-history move also rewrites other extensions' dependency lists that point at the renamed migrations, not just this extension's own rows. phpBB reads those lists when reverting migrations.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Author: bonelifer

ext.php

@@ -52,7 +52,10 @@ public function is_enableable()
 
 		if ($this->container->get('ext.manager')->is_enabled(self::OLD_EXT_NAME))
 		{
-			return ['Disable the old "' . self::OLD_EXT_NAME . '" extension first (keep its data, do not delete it).'];
+			$language = $this->container->get('language');
+			$language->add_lang('install_editedpostsunread', 'phpbbmodders/editedpostsunread');
+
+			return $language->lang('EDITEDPOSTSUNREAD_DISABLE_OLD', self::OLD_EXT_NAME);
 		}
 
 		return true;
@@ -119,16 +122,20 @@ protected function move_old_install()
 
 		foreach ($rows as $row)
 		{
-			if ($this->new_class_name($row['migration_name']) === $row['migration_name'])
+			// Other extensions' migrations may depend on ours, so their
+			// dependency lists are rewritten too, not just our own rows
+			$old_depends_on = unserialize($row['migration_depends_on'], ['allowed_classes' => false]);
+			$old_depends_on = is_array($old_depends_on) ? $old_depends_on : [];
+			$depends_on = array_map([$this, 'new_class_name'], $old_depends_on);
+			$name = $this->new_class_name($row['migration_name']);
+
+			if ($name === $row['migration_name'] && $depends_on === $old_depends_on)
 			{
 				continue;
 			}
 
-			$depends_on = unserialize($row['migration_depends_on'], ['allowed_classes' => false]);
-			$depends_on = is_array($depends_on) ? array_map([$this, 'new_class_name'], $depends_on) : [];
-
 			$db->sql_query('UPDATE ' . $prefix . 'migrations SET ' . $db->sql_build_array('UPDATE', [
-				'migration_name'		=> $this->new_class_name($row['migration_name']),
+				'migration_name'		=> $name,
 				'migration_depends_on'	=> serialize($depends_on),
 			]) . " WHERE migration_name = '" . $db->sql_escape($row['migration_name']) . "'");
 		}

language/en/install_editedpostsunread.php

@@ -40,4 +40,5 @@
 
 $lang = array_merge($lang, [
 	'EDITEDPOSTSUNREAD_NOT_ENABLEABLE'	=> 'Mark Edited Posts Unread could not be enabled. The minimum requirements of phpBB 3.3.19 and/or PHP 7.4.0 were not satisfied.',
+	'EDITEDPOSTSUNREAD_DISABLE_OLD'	=> 'Disable the old “%s” extension first. Keep its data; do not delete it.',
 ]);